[ 
https://issues.apache.org/jira/browse/OFBIZ-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925848#comment-15925848
 ] 

Jacques Le Roux commented on OFBIZ-9229:
----------------------------------------

bq. Maybe you should have waited until a discussion was started and a 
conclusion reached. 
I don't wait when there is an issue in the patch, see my commit comment. What I 
could have done is fixing the problem. But then I'd have 2 commits to revert if 
ever we want to remove the grid feature. I doubt we will, but I still prefer to 
wait the conclusion of the current discussion on the grid in dev ML.
bq. Whether or not I use grids in a project is irrelevant.
This question because you privately asked me to commit this, as if urgent, and 
I thought it was blocking you in a custom project.

Note also that I reverted because I was unsure there were no other cases like 
that in the related patches I committed ("refactor list related forms into 
grid"). I know for sure now that there are none. So it's not a big deal to fix 
the 3 case I reported in commits comments

> refactor list related forms in Cost widgets
> -------------------------------------------
>
>                 Key: OFBIZ-9229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9229
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9229-CostWidgets.xml.patch
>
>
> Refactoring various list forms into grids
> Refactoring various list form references in screen widgets



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to