Suraj Khurana created OFBIZ-9281: ------------------------------------ Summary: Code Improvement on Product Config Key: OFBIZ-9281 URL: https://issues.apache.org/jira/browse/OFBIZ-9281 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana Priority: Minor
I noticed a couple of code improvements on product config current code. Here is the reference: - In ProductConfigWorker.fillProductConfigWrapper() method, currently, we only check parameters map, while it is possible in a business environment that user can submit required fields values in request attributes as well. So here getCombinedMap method can be used to make it more efficient. - While calling constructor of ConfigOption (ConfigOption(ConfigOption co)), some private members should also be copied, like componentOptions etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)