[
https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000101#comment-16000101
]
Pierre Smits edited comment on OFBIZ-9346 at 5/7/17 10:32 PM:
--------------------------------------------------------------
Agreement = (in German) Vereinbarung, Vertrag, Übereinkomen, Übereinstimmung,
etc. There is plenty more to choose from.
So we have [1]:
* Vereinbarungsbedingungen = *Bedingungen* der Vereinbarung
* Vereinbarungselemente = *Elemente* der Vereinbarung
* Vereinbarungsarbeitseinsätse = *Arbeiteinsätze* der Vereinbarung
* Vereinbarungsrollen = *Rollen* der Vereinbarung
* Vereinbaurngsparteien = *Parteien* der Vereinbarung
* Vereinbarungsinhälte = *Inhälte* der Vereinbarung
Nothing exists without context (even in German):
When you're within the context of an an Agreement (Vereinbarung in accounting,
Vertrag in Product) anything in there is related to that context (see
https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=8000)
So even in German (as in English, Dutch, and probably a lot more languages) the
following delivers a better user experience
* Bedingungen
* Elemente
* Arbeiteinsätze
* Rollen
* Parteien
* Inhälte
than the list under [1]
So we have:
# Terms of the agreement: <property key="AccountingAgreementItemTerms">
# Terms of the agreement item <property key="AccountingAgreementItemTerms">
# The page title for editing (and the list of) the terms of the billing
account: <property key="PageTitleEditBillingAccountTerms">
# the page title for the list of temrs of an agreement<property
key="PageTitleListAgreementItemTerms">
# The page title for the terms of the agreement <property
key="PageTitleListAgreementTerms">
# The terms for the order when entering the order <property
key="OrderOrderEntryOrderTerms">
# The (list of) terms for the quote <property key="OrderOrderQuoteListTerms">
# The terms for the quote <property key="OrderOrderQuoteTerms">
# The terms for a party <property key="PartyTerms">
# The 'special terms for a workeffort <property
key="FormFieldTitle_specialTerms">
# The 'common' quote terms <property key="CommonQuoteTerms">
# The 'common' terms <property key="CommonTerms"> (of course!!)
They al mean the same: the terms of the object in the context (screen) shown.
Removing labels (that mean the same) and replacing them with 1 shared fits as
much in the OFBiz (slim-down) vision as any other refactoring effort that
reduces the footprint of OFBiz. Keeping labels in each/any component that mean
the same (given the context its is applied in) is the opposite of that. When
the context is the same the labels should go in CommonUiLabels.xml (another
part of the OFBiz vision).
Terms (conditions) is just 1 example, but the principle applies to al that
share the same meaning in a different context: ID, Content, Payment, Invoice,
Product, Party, Role, etc.
If an adopter feels that it is *not* adequate enough for his implementation, he
- as always - is free to adjust his implementation to whatever he desires. The
same goes for any OFBiz contributor that needs to implement OFBiz to
needs/wants/etc. of his customer.
was (Author: pfm.smits):
Agreement = (in German) Vereinbarung, Vertrag, Übereinkomen, Übereinstimmung,
etc. There is plenty more to choose from.
So we have [1]:
* Vereinbarungsbedingungen = *Bedingungen* der Vereinbarung
* Vereinbarungselemente = *Elemente* der Vereinbarung
* Vereinbarungsarbeitseinsätse = *Arbeiteinsätse* der Vereinbarung
* Vereinbarungsrollen = *Rollen* der Vereinbarung
* Vereinbaurngsparteien = *Parteien* der Vereinbarung
* Vereinbarungsinhälte = *Inhälte* der Vereinbarung
Nothing exists without context (even in German):
When you're within the context of an an Agreement (Vereinbarung in accounting,
Vertrag in Product) anything in there is related to that context (see
https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=8000)
So even in German (as in English, Dutch, and probably a lot more languages) the
following delivers a better user experience
* Bedingungen
* Elemente
* Arbeiteinsätse
* Rollen
* Parteien
* Inhälte
than the list under [1]
So we have:
# Terms of the agreement: <property key="AccountingAgreementItemTerms">
# Terms of the agreement item <property key="AccountingAgreementItemTerms">
# The page title for editing (and the list of) the terms of the billing
account: <property key="PageTitleEditBillingAccountTerms">
# the page title for the list of temrs of an agreement<property
key="PageTitleListAgreementItemTerms">
# The page title for the terms of the agreement <property
key="PageTitleListAgreementTerms">
# The terms for the order when entering the order <property
key="OrderOrderEntryOrderTerms">
# The (list of) terms for the quote <property key="OrderOrderQuoteListTerms">
# The terms for the quote <property key="OrderOrderQuoteTerms">
# The terms for a party <property key="PartyTerms">
# The 'special terms for a workeffort <property
key="FormFieldTitle_specialTerms">
# The 'common' quote terms <property key="CommonQuoteTerms">
# The 'common' terms <property key="CommonTerms"> (of course!!)
They al mean the same: the terms of the object in the context (screen) shown.
Removing labels (that mean the same) and replacing them with 1 shared fits as
much in the OFBiz (slim-down) vision as any other refactoring effort that
reduces the footprint of OFBiz. Keeping labels in each/any component that mean
the same (given the context its is applied in) is the opposite of that. When
the context is the same the labels should go in CommonUiLabels.xml (another
part of the OFBiz vision).
Terms (conditions) is just 1 example, but the principle applies to al that
share the same meaning in a different context: ID, Content, Payment, Invoice,
Product, Party, Role, etc.
If an adopter feels that it is *not* adequate enough for his implementation, he
- as always - is free to adjust his implementation to whatever he desires. The
same goes for any OFBiz contributor that needs to implement OFBiz to
needs/wants/etc. of his customer.
> Maximise utilisation of common labels in AccountingMenus.xml
> ------------------------------------------------------------
>
> Key: OFBIZ-9346
> URL: https://issues.apache.org/jira/browse/OFBIZ-9346
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Minor
> Attachments: OFBIZ-9346-AccountingMenus-v2.patch,
> OFBIZ-9346-AccountingMenus.xml.patch, Screen Shot 2017-05-07 at 23.19.41.png,
> Screen Shot 2017-05-08 at 00.21.24.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
