[ 
https://issues.apache.org/jira/browse/OFBIZ-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055232#comment-16055232
 ] 

Jacopo Cappellato commented on OFBIZ-9392:
------------------------------------------

I have reviewed the patch and it looks good to me, thank you for your work!
I suggest to commit the work to trunk: further tests and enhancements can be 
done there.


> Refactor CatalinaContainer
> --------------------------
>
>                 Key: OFBIZ-9392
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9392
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9392.patch, OFBIZ-9392.patch, OFBIZ-9392.patch, 
> OFBIZ-9392.patch
>
>
> The implementation of CatalinaContainer.java is currently very verbose, has 
> replicated code, and is difficult to navigate.
> The objective of this JIRA is to breakup the logic into smaller manageable 
> functions to allow for further enhancements in the future.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to