[
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097233#comment-16097233
]
Taher Alkhateeb edited comment on OFBIZ-9501 at 7/22/17 10:36 AM:
------------------------------------------------------------------
Hi Prakhar,
Thank you for your work, its really great to see people contributing to this
JIRA.
I have a question: Aren't the below records from your patch belonging to the
"project" component? If yes wouldn't it be better to move it to that component
instead? I'm not sure if there are also more records, that was just a quick
skim.
{code:xml}
<WorkEffortContentType workEffortContentTypeId="PROJECT_DISCUSSION"
description="Project Discussion" parentTypeId=""/>
<WorkEffortContentType workEffortContentTypeId="PROJECT_UPDATE"
description="Project Update" parentTypeId=""/>
<WorkEffortContentType workEffortContentTypeId="PROJECT_SPEC"
description="Project Specification" parentTypeId=""/>
<WorkEffortPurposeType description="Project"
workEffortPurposeTypeId="WEPT_PROJECT"/>
<WorkEffortPurposeType description="Phase"
workEffortPurposeTypeId="WEPT_PHASE"/>
<WorkEffortType description="Workflow Process" hasTable="N" parentTypeId=""
workEffortTypeId="WORK_FLOW"/>
<WorkEffortType description="Workflow Activity" hasTable="N" parentTypeId=""
workEffortTypeId="ACTIVITY"/>
<WorkEffortType description="Task" hasTable="N" parentTypeId=""
workEffortTypeId="TASK"/>
<WorkEffortType description="Milestone" hasTable="N" parentTypeId=""
workEffortTypeId="MILESTONE"/>
<WorkEffortType description="Event" hasTable="N" parentTypeId=""
workEffortTypeId="EVENT"/>
<WorkEffortType description="Available" hasTable="N" parentTypeId=""
workEffortTypeId="AVAILABLE"/>
<WorkEffortType description="Program" hasTable="N" parentTypeId=""
workEffortTypeId="PROGRAM"/>
<WorkEffortType description="Project" hasTable="N" parentTypeId=""
workEffortTypeId="PROJECT"/>
<WorkEffortType description="Project Phase" hasTable="N" parentTypeId=""
workEffortTypeId="PHASE"/>
{code}
was (Author: taher):
Hi Prakhar,
Thank you for your work, its really great to see people contributing to this
JIRA.
I have a question: Aren't the below records from your patch belonging to the
"project" component? If yes wouldn't it be better to move it to that component
instead? I'm not sure if there are also more records, that was just a quick
skim.
{code: xml}
<WorkEffortContentType workEffortContentTypeId="PROJECT_DISCUSSION"
description="Project Discussion" parentTypeId=""/>
<WorkEffortContentType workEffortContentTypeId="PROJECT_UPDATE"
description="Project Update" parentTypeId=""/>
<WorkEffortContentType workEffortContentTypeId="PROJECT_SPEC"
description="Project Specification" parentTypeId=""/>
<WorkEffortPurposeType description="Project"
workEffortPurposeTypeId="WEPT_PROJECT"/>
<WorkEffortPurposeType description="Phase"
workEffortPurposeTypeId="WEPT_PHASE"/>
<WorkEffortType description="Workflow Process" hasTable="N" parentTypeId=""
workEffortTypeId="WORK_FLOW"/>
<WorkEffortType description="Workflow Activity" hasTable="N" parentTypeId=""
workEffortTypeId="ACTIVITY"/>
<WorkEffortType description="Task" hasTable="N" parentTypeId=""
workEffortTypeId="TASK"/>
<WorkEffortType description="Milestone" hasTable="N" parentTypeId=""
workEffortTypeId="MILESTONE"/>
<WorkEffortType description="Event" hasTable="N" parentTypeId=""
workEffortTypeId="EVENT"/>
<WorkEffortType description="Available" hasTable="N" parentTypeId=""
workEffortTypeId="AVAILABLE"/>
<WorkEffortType description="Program" hasTable="N" parentTypeId=""
workEffortTypeId="PROGRAM"/>
<WorkEffortType description="Project" hasTable="N" parentTypeId=""
workEffortTypeId="PROJECT"/>
<WorkEffortType description="Project Phase" hasTable="N" parentTypeId=""
workEffortTypeId="PHASE"/>
{code}
> move all data in applications to the datamodel component
> --------------------------------------------------------
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: Upcoming Release
> Reporter: Taher Alkhateeb
> Priority: Minor
> Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-002.patch
>
>
> As per a community [discussion
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
> we decided to move all data (seed, seed-initial, demo) to the datamodel
> component. and to also reduce and cleanup this data to ease debugging and
> maintenance.
> After moving all the data, the directory and file structure would be similar
> to the below:
> data/
> ├── demo
> │ ├── AccountingDemoData.xml
> │ ├── CommonDemoData.xml
> │ ├── ContentDemoData.xml
> │ ├── HumanresDemo.xml
> │ ├── ManufacturingDemoData.xml
> │ ├── MarketingDemoData.xml
> │ ├── OrderDemoData.xml
> │ ├── PartyDemoData.xml
> │ ├── ProductDemoData.xml
> │ ├── ShipmentDemoData.xml
> │ └── WorkEffortDemoData.xml
> ├── seed
> │ ├── AccountingSeedData.xml
> │ ├── CommonSeedData.xml
> │ ├── ContentSeedData.xml
> │ ├── HumanresSeedData.xml
> │ ├── ManufacturingSeedData.xml
> │ ├── MarketingSeedData.xml
> │ ├── OrderSeedData.xml
> │ ├── PartySeedData.xml
> │ ├── ProductSeedData.xml
> │ ├── ShipmentSeedData.xml
> │ └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
