[
https://issues.apache.org/jira/browse/OFBIZ-9530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kyra Pritzel-Hentley updated OFBIZ-9530:
----------------------------------------
Attachment: OFBIZ-9530_PaymentGatewayServices_bugfix.patch
In this patch I implement the above suggested code. If authresult is null then
the error should be logged and the service should return.
> Missing action in empty if-statement in accounting.PaymentGatewayServices
> -------------------------------------------------------------------------
>
> Key: OFBIZ-9530
> URL: https://issues.apache.org/jira/browse/OFBIZ-9530
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: Trunk
> Reporter: Kyra Pritzel-Hentley
> Priority: Minor
> Attachments: OFBIZ-9530_PaymentGatewayServices_bugfix.patch
>
>
> In the method _processAuthResult_ line 1889 there is an empty if-statement
> for the case that authResult is null. It seems like somebody was planning to
> cover the case but forgot to add code.
> I would suggest to return a service error when the authResult is null since
> otherwise it cannot be determined if the payment is authorized or not.
> {code:java}
> boolean authResultOk = authResult.booleanValue();
>
> if (authResultOk) {
> orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
> } else {
> orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
