Jacques Le Roux commented on OFBIZ-9441:

Hi Taher,
I continued the review,
# I could not completely apply the changes README.md. I guess you need to 
# found a typo :)
bq. Debug.logImportant("Creating foreign key indcies...", module);
# A question: in few places, why did you prefer ArrayList over LinkedList?
# Among 
 -l,--load-data <key=value>   Creates tables/load data e.g:
                              -l readers=seed,demo,ext
                              -l file=/tmp/dataload1.xml,/tmp/dataload2.xml
                              -l dir=directory/of/files
                              -l component=base
                              -l delegator=default
                              -l group=org.apache.ofbiz
                              -l timeout=7200
                              -l create-pks
                              -l drop-pks
                              -l create-constraints
                              -l drop-constraints
                              -l create-fks
                              -l maintain-txs
                              -l try-inserts
                              -l repair-columns
                              -l continue-on-failure
I tried to use several parameters (also with several combinations) at the same 
time w/o success, but not sure of the real syntax.
Because using 
bq. -l readers=seed,demo,ext delegator=default (etc.) 
did not work I used something like
bq. java -jar build/libs/ofbiz.jar -l readers=seed,demo,ext -l 
delegator=default group=org.apache.ofbiz (etc.)
# And finally while I tried (g is a shorcut for gradlew)
bq. C:\projectsASF\ofbiz>g cleanAll && g eclipse build && java -jar 
build/libs/ofbiz.jar -l readers=seed,demo,ext
I got the attached log with errors at end. I have no pending changes in this 
instance but the patch here.

> Refactor OFBiz containers and remove StartupCommandToArgsAdapter
> ----------------------------------------------------------------
>                 Key: OFBIZ-9441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9441
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9441-fix-continue-on-failure.patch, 
> OFBIZ-9441.patch, OFBIZ-9441.patch, OFBIZ-9441.patch
> We have already refactored the ComponentContainer and CatalinaContainer in 
> OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the 
> following:
> - Refactor EntityDataLoadContainer to simplify the code and remove 
> dependencies on "args" and convert instead the logic to use StartupCommands
> - Refactor TestRunContainer the same way
> - Delete the class StartupCommandToArgsAdapter
> - Update README.md to reflect the changes and updates and cleanup old 
> references.

This message was sent by Atlassian JIRA

Reply via email to