Taher Alkhateeb commented on OFBIZ-9441:

Hi Jacques, thank you for the review. Replying:

1- yeah .. that sucks :( it's because of the time delay in committing this 
stuff. I will merge the conflicts and reattach
2- Thank you .. will take care of it
3- To remain consistent with the rest of the framework. Anyway, it makes almost 
no difference given the very small sizes of the data structures
4- every "key=value" needs its own --load-data or -l. So the syntax should be 
./gradlew "ofbiz -l readers=seed,demo,ext -l delegator=default -l 
5- Why are using java -jar? just use ./gradlew and execute your commands to 
avoid confusion or misspelling of things. Anyway, it seems like the errors are 
not related to my work but rather improperly configured data. It's just a bunch 
of foreign key violations and things like that.

> Refactor OFBiz containers and remove StartupCommandToArgsAdapter
> ----------------------------------------------------------------
>                 Key: OFBIZ-9441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9441
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: log with errors.txt, 
> OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, 
> OFBIZ-9441.patch
> We have already refactored the ComponentContainer and CatalinaContainer in 
> OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the 
> following:
> - Refactor EntityDataLoadContainer to simplify the code and remove 
> dependencies on "args" and convert instead the logic to use StartupCommands
> - Refactor TestRunContainer the same way
> - Delete the class StartupCommandToArgsAdapter
> - Update README.md to reflect the changes and updates and cleanup old 
> references.

This message was sent by Atlassian JIRA

Reply via email to