[
https://issues.apache.org/jira/browse/OFBIZ-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9635:
---------------------------------
Attachment: OFBIZ-9635_org.apache.ofbiz.security_bugfixes.patch
- Diamond Operators fixed
- Line 90: changed the assigned field to private, since it is a final class and
protected is a confusing declaration at this point and the field is only used
in this class
PS: package security isn't available to choose from, while creating a new sub
> [FB] Package org.apache.ofbiz.security
> --------------------------------------
>
> Key: OFBIZ-9635
> URL: https://issues.apache.org/jira/browse/OFBIZ-9635
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-9635_org.apache.ofbiz.security_bugfixes.patch
>
>
> SecurityFactory.java:-1, CI_CONFUSED_INHERITANCE, Priorität: Niedrig
> CI: Class org.apache.ofbiz.security.SecurityFactory$OFBizSecurity is final
> but declares protected field
> org.apache.ofbiz.security.SecurityFactory$OFBizSecurity.simpleRoleEntity
> This class is declared to be final, but declares fields to be protected.
> Since the class is final, it can not be derived from, and the use of
> protected is confusing. The access modifier for the field should be changed
> to private or public to represent the true use for the field.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
