[ 
https://issues.apache.org/jira/browse/OFBIZ-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9729:
-----------------------------------
    Attachment: OFBIZ-9729_org.apache.ofbiz.order_bugfixes.patch

class OrderManagerEvents
 - removed null-checks and added equals to prevent NPE.

> [FB] org.apache.ofbiz.order
> ---------------------------
>
>                 Key: OFBIZ-9729
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9729
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Julian Leichert
>            Priority: Minor
>         Attachments: OFBIZ-9729_org.apache.ofbiz.order_bugfixes.patch
>
>
> OrderManagerEvents.java:101, NP_NULL_ON_SOME_PATH
> - NP: Possible null pointer dereference of results in 
> org.apache.ofbiz.order.OrderManagerEvents.processOfflinePayments(HttpServletRequest,
>  HttpServletResponse)
> There is a branch of statement that, if executed, guarantees that a null 
> value will be dereferenced, which would generate a NullPointerException when 
> the code is executed. Of course, the problem might be that the branch or 
> statement is infeasible and that the null pointer exception can't ever be 
> executed; deciding that is beyond the ability of FindBugs.
> OrderManagerEvents.java:212, NP_NULL_ON_SOME_PATH
> - NP: Possible null pointer dereference of results in 
> org.apache.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(HttpServletRequest,
>  HttpServletResponse)
> There is a branch of statement that, if executed, guarantees that a null 
> value will be dereferenced, which would generate a NullPointerException when 
> the code is executed. Of course, the problem might be that the branch or 
> statement is infeasible and that the null pointer exception can't ever be 
> executed; deciding that is beyond the ability of FindBugs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to