[ 
https://issues.apache.org/jira/browse/OFBIZ-9728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9728.
----------------------------------
    Resolution: Fixed

Thanks Liang,

Your patch is in trunk at revision 1809270; previous branches are not concerned/

The pricat component was missing in Jira I added it.

2 small remarks:
# We don't uset tabs but 4 spaces instead
# Please create your patches from the root to have a complete path from there. 
Easier when patching

See 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
 for details (look for "Guidelines" notably, reading the whole page is worth it)

> Empty rows affect the imported
> ------------------------------
>
>                 Key: OFBIZ-9728
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9728
>             Project: OFBiz
>          Issue Type: Bug
>          Components: pricat
>    Affects Versions: Trunk
>            Reporter: zhang.liang
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Release
>
>         Attachments: SamplePricatParser.java.patch
>
>
> ofbiz-plugins pricat Component
> Affected by the empty rows, the number of rows actually imported is less than 
>  rows of excel.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to