Julian Leichert created OFBIZ-9779:
--------------------------------------
Summary: [FB] org.apache.ofbiz.product.price
Key: OFBIZ-9779
URL: https://issues.apache.org/jira/browse/OFBIZ-9779
Project: OFBiz
Issue Type: Sub-task
Components: product
Affects Versions: Trunk
Reporter: Julian Leichert
Priority: Minor
PriceServices.java:294, RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE
- RCN: Redundant nullcheck of defaultPriceValue which is known to be null in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This method contains a redundant check of a known null value against the
constant null.
PriceServices.java:294, NP_LOAD_OF_KNOWN_NULL_VALUE
- NP: Load of known null value in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
The variable referenced at this point is known to be null due to an earlier
check against null. Although this is valid, it might be a mistake (perhaps you
intended to refer to a different variable, or perhaps the earlier check to see
if the variable is null should have been a check to see if it was non-null).
PriceServices.java:523, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
PriceServices.java:525, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
PriceServices.java:527, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
PriceServices.java:529, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
PriceServices.java:531, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
PriceServices.java:533, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
PriceServices.java:535, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
PriceServices.java:537, ES_COMPARING_STRINGS_WITH_EQ
- ES: Comparison of String objects using == or != in
org.apache.ofbiz.product.price.PriceServices.calculateProductPrice(DispatchContext,
Map)
This code compares java.lang.String objects for reference equality using the ==
or != operators. Unless both strings are either constants in a source file, or
have been interned using the String.intern() method, the same string value may
be represented by two different String objects. Consider using the
equals(Object) method instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
