[ 
https://issues.apache.org/jira/browse/OFBIZ-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178918#comment-16178918
 ] 

Julian Leichert commented on OFBIZ-9780:
----------------------------------------

Does it make sense to pass ServletRequest as a Parameter, maybe pass 
HttpServletRequest instead?
So it wouldn't be necessary to cast.

> [FB] org.apache.ofbiz.product.catalog
> -------------------------------------
>
>                 Key: OFBIZ-9780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9780
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Julian Leichert
>            Priority: Minor
>
> CatalogWorker.java:103, BC_UNCONFIRMED_CAST
> - BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to 
> javax.servlet.http.HttpServletRequest in 
> org.apache.ofbiz.product.catalog.CatalogWorker.getPartyCatalogs(ServletRequest)
> This cast is unchecked, and not all instances of the type casted from can be 
> cast to the type it is being cast to. Check that your program logic ensures 
> that this cast will not fail.
> CatalogWorker.java:158, BC_UNCONFIRMED_CAST
> - BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to 
> javax.servlet.http.HttpServletRequest in 
> org.apache.ofbiz.product.catalog.CatalogWorker.getCurrentCatalogId(ServletRequest)
> This cast is unchecked, and not all instances of the type casted from can be 
> cast to the type it is being cast to. Check that your program logic ensures 
> that this cast will not fail. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to