[ 
https://issues.apache.org/jira/browse/OFBIZ-6054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224000#comment-16224000
 ] 

Oleg Andreyev commented on OFBIZ-6054:
--------------------------------------

Hi Jacques,

I saw this code and my change does not in a conflict with it. Initially, it was 
like "if the form exists" then OFBIZ-7130 add a clause and it becomes "if form 
and the field of this form both exist".  My change simplifies it to "if a field 
of the form exists".  As I understand the code and how jquery works it does not 
break anything but fix the issue. 

I did quick tests in party profile (including creating an email - OFBIZ-7130 
situation) and in quick checkout from. The change doesn't break them. So, I 
think the fix is quite safe.

Personally, I think it would better to make changes in the framework to settle 
this problem with ids. I mean if we create new form A by inheritance from form 
B then fields inherited from B must have ids based on A. It looks justified. 
But such a solution would be overkill for this particular issue. Which I don't 
like just because it spoils the first impression when a newbie tries to explore 
a new system following the documentation.

> ofbizsetup cannot create first customer. problem with state/province dropdown
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-6054
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6054
>             Project: OFBiz
>          Issue Type: Bug
>          Components: commonext
>    Affects Versions: Trunk
>            Reporter: Wai
>            Assignee: Jacques Le Roux
>         Attachments: newcust_setup.diff
>
>
> -use empty database.
> -go to url. https://localhost:8443/ofbizsetup/control/firstcustomer
> notice that when entering the postal address, the state/province dropdown is 
> empty and remains empty regardless of selection of the country dropdown.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to