[
https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247812#comment-16247812
]
Jacques Le Roux commented on OFBIZ-9465:
----------------------------------------
HI Aditya,
Will you create a subtask for require.js as annouced in the description? If you
do please make it a subtask of OFBIZ-1319 where all started.
About that, one point to note as mentionned [~amardeepsj] in
[OFBIZ-7758|https://s.apache.org/gkSm]
bq. One more thing I want to add here that, require.js works well for js module
loading. Please refer: http://requirejs.org/docs/faq-advanced.html#css and here
we are talking about css file.
Thanks!
> Replace Inline Javascript with External Javascript
> ---------------------------------------------------
>
> Key: OFBIZ-9465
> URL: https://issues.apache.org/jira/browse/OFBIZ-9465
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Aditya Sharma
> Assignee: Aditya Sharma
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9465.patch, OFBIZ-9465.patch, OFBIZ-9465.patch,
> OFBIZ-9465.patch, OFBIZ-9465_example.patch, OFBIZ-9465_example.patch
>
>
> As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline
> javascript for various macros like renderLookupField,
> makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be
> replaced with a generic code written as external javascript. Generic
> Javascript code should be written in OfbizUtil.js and appropriate classes or
> identifiers should be used for applying that. Any additional data can be
> passed with HTML 5 custom data attribute
> (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes).
> As suggested by Jacques in https://s.apache.org/y8P1 will introduce
> require.js for the split javascript files in a sub-task.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
