[
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265927#comment-16265927
]
Rishi Solanki commented on OFBIZ-9501:
--------------------------------------
Taher,
Thank you for your input, I also think on that data on the similar points. But
while checking the dependencies I see the data is on seed reader and code will
also have checks on those data to run the component. For the manufacturing help
data is only uses the locale demonstration of manufacturing component only. For
other components help data is only in US English, so I moved that data as well.
In my previous commits I moved the similar data for other components, so if we
decide to keep such configuration data to the component specific location then
I'll make changes in those files as well. I agree on the point that
configuration data should be with component only. But code base uses that data
in several conditions and seed reader direct me to move that data as well.
On the whole, we can rethink on this and keep the seed reader (for now) at
component location. Then we can think on seed reader is appropriate for
configuration data or not. Alternatively if we think seed reader is fine for
configuration data then we can decide where to keep seed data. Like are we fine
to have seed data of one component in data model as well as in some specific
component (Party, Manufacturing etc.). Putting all this to maintain consistency
and developers ease, because for me when I search for some data in files I
usually expect that data to some location.
Please suggest how should we proceed, thanks again for your help on this. It
really help to better understand the things you want to achieve from this
ticket. Due to the same reason I first add the patch on the ticket and after
feedback commit the changes.
> Move all data in applications to the datamodel component
> --------------------------------------------------------
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: Upcoming Release
> Reporter: Taher Alkhateeb
> Assignee: Rishi Solanki
> Priority: Minor
> Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch,
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch,
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch,
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
> we decided to move all data (seed, seed-initial, demo) to the datamodel
> component. and to also reduce and cleanup this data to ease debugging and
> maintenance.
> After moving all the data, the directory and file structure would be similar
> to the below:
> data/
> ├── demo
> │ ├── AccountingDemoData.xml
> │ ├── CommonDemoData.xml
> │ ├── ContentDemoData.xml
> │ ├── HumanresDemo.xml
> │ ├── ManufacturingDemoData.xml
> │ ├── MarketingDemoData.xml
> │ ├── OrderDemoData.xml
> │ ├── PartyDemoData.xml
> │ ├── ProductDemoData.xml
> │ ├── ShipmentDemoData.xml
> │ └── WorkEffortDemoData.xml
> ├── seed
> │ ├── AccountingSeedData.xml
> │ ├── CommonSeedData.xml
> │ ├── ContentSeedData.xml
> │ ├── HumanresSeedData.xml
> │ ├── ManufacturingSeedData.xml
> │ ├── MarketingSeedData.xml
> │ ├── OrderSeedData.xml
> │ ├── PartySeedData.xml
> │ ├── ProductSeedData.xml
> │ ├── ShipmentSeedData.xml
> │ └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
