[ 
https://issues.apache.org/jira/browse/OFBIZ-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275490#comment-16275490
 ] 

Aditya Sharma edited comment on OFBIZ-9852 at 12/2/17 9:04 AM:
---------------------------------------------------------------

Replaced inline js from renderHyperlinkString macro to external js in 
OfbizUtils.js
Done following:
Used custom data attributes: data-dialog-url, data-dialog-width, 
data-dialog-height, data-dialog-title and data-dialog-params in macro to pass 
data
Used attribute selector to find elements for adding dialog
Removed div for uniqueItemName from markup and prepared that div dynamically in 
js code.

Steps to verify:
Click on Example Id on Ajax Examples page 
(https://localhost:8443/example/control/authview/findExampleAjax) dialog box 
appears.
Links section of 
FormWidgetExamples(https://localhost:8443/example/control/FormWidgetExamples).
Open layered modal for dialog and delete button for confirm box (added in 
plugins patch). 


was (Author: aditya.sharma):
Replaced inline js from renderHyperlinkString macro to external js in 
OfbizUtils.js
Done following:
Used custom data attributes: data-dialog-url, data-dialog-width, 
data-dialog-height, data-dialog-title and data-dialog-params in macro to pass 
data
Used attribute selector to find elements for adding dialog
Removed div for uniqueItemName from markup and prepared that div dynamically in 
js code.

Steps to verify:
Click on Example Id on Ajax Examples page 
(https://localhost:8443/example/control/authview/findExampleAjax) dialog box 
appears.
Links section of FormWidgetExamples. Open layered modal for dialog and delete 
button for confirm box. 
https://localhost:8443/example/control/FormWidgetExamples

> Replace Inline js with External js in makeHyperlinkString macro
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-9852
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9852
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>         Attachments: OFBIZ-9852.patch, OFBIZ-9852_plugins.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to