[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350429#comment-16350429 ]
Jacques Le Roux commented on OFBIZ-10146: ----------------------------------------- OK the patch does not completely apply, it seems benign, I'll look at it ASAP... > Removing of loadBestSellingCategory and all related methods in > CategoryServices.xml > ----------------------------------------------------------------------------------- > > Key: OFBIZ-10146 > URL: https://issues.apache.org/jira/browse/OFBIZ-10146 > Project: OFBiz > Issue Type: Improvement > Components: product > Affects Versions: Trunk > Reporter: Dennis Balkir > Assignee: Jacques Le Roux > Priority: Minor > Attachments: OFBIZ-10146.patch > > > While doing some conversions from MiniLang to Groovy, I stumbled across these > methods: > {{loadBestSellingCategory}} > {{RemoveProductFromBestSellCategory}} > {{AddProductToBestSellCategory}} > {{FindCategoryChild}} > {{FindBestSellingProduct}} > These are all in {{CategoryServices.xml}}. > I started realizing, that the simple-method {{loadBestSellingCategory}} > doesn't work right (there are some logical failures in it) and while fixing > it, > I searched for places where this is used, but couldn't find any. > I started looking deeper into it and found that all of these methods are > never used anywhere in OFBiz, neither are the services which are declared for > this methods. > This is why I propose to remove them; they have no real use, since they don't > work properly, and also are never used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)