[ 
https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351745#comment-16351745
 ] 

Aditya Sharma edited comment on OFBIZ-10012 at 2/4/18 11:15 AM:
----------------------------------------------------------------

Here is the solution patch.

Passed all the parameters as data-* attribute values.

Improved handling of width, height, and position.

Removed checks for showDescription as it is already handled at  
org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java:2199

Added CSS as Browser styling which causes the cursor to become pointer was not 
applied to the dynamic element.

Added a call to bindObservers fieldlookup.js so that lookup works on dynamic 
elements of LookupForm too.

Added examples for call_fieldlookup3 i.e. Popup lookup field with description 
and Layered lookup field with autocompletion, description at right and optional 
target.

Although call_fieldlookup2 and call_fieldlookup3 didn’t work initially & 
requires a separate work. The lookup opens but when clicked on the value it is 
not set. This is an old way & not used now. 
[https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples]

ofbizUtils.js was being included twice for the content component as included in 
main-decorator also so removed that too.

Added check for form name in the beginning but as form name is extracted 
directly from element’s form I guess it will pass in most of the cases & the 
problem will not arise.

 

Verify:

Lookup Fields: [https://localhost:8443/example/control/FormWidgetExamples]

Owner Content Id: [https://localhost:8443/content/control/findContent] Here, it 
can be also verified that a lookup from a lookup works. Click the link for 
ownerContentId and then click any link for lookup from the lookup.

 

Thanks Deepak for the guidance provided.

Please review.


was (Author: aditya.sharma):
Here is the solution patch. 

Passed all the parameters as data-* attribute values.

Improved handling of width, height and position.

Removed checks for showDescription as it is already handled at  
org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java:2199

Added css as Browser styling which causes cursor to become pointer was not 
applied for the dynamic element .

Added call to bindObservers fieldlookup.js so that lookup works on dynamic 
elements of LookForm too.

Added examples for call_fieldlookup3 i.e. Popup lookup field with description 
and Layered lookup field with autocompletion, description at right and optional 
target.

Although call_fieldlookup2 and call_fieldlookup3 didn’t worked initially & 
requires a separate work. The lookup opens but when clicked on value it is not 
set. This is a old way & not used now. 
[https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples]

ofbizUtils.js was being included twice for content component as included in 
main-decorator also so removed that too.

Added check for form name in the beginning but as form name is extracted 
directly from element’s form I guess it will pass in most of the cases & the 
problem will not arise.

 

Verify:

Lookup Fields: [https://localhost:8443/example/control/FormWidgetExamples]

Owner Content Id: [https://localhost:8443/content/control/findContent] Here, it 
can be also verified that a lookup from a lookup works. Click link for 
ownerContentId and then click any link for lookup from the lookup.

 

Thanks Deepak for the guidance provided.

Please review.

> Alert message : "Developer: for lookups to work you must provide a form 
> name!" appears when try to select contentId from Lookup
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Sonal Patwari
>            Assignee: Deepak Dixit
>            Priority: Blocker
>         Attachments: ContentSearchOptionsAlertShowing (1).png, 
> OFBIZ-10012.patch, OFBIZ-10012_plugins.patch
>
>
> Steps to reproduce:
> 1. Go to [Content 
> Component|https://demo-trunk.ofbiz.apache.org/content/control/main]
> 2. Click on Content from 
> [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent].
> 3. Click on the Advanced Search button 
> [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions].
> 4. Provide Content Id.
> 5. User should be able to see the alert message.
> 6. For reference screenshot is attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to