Dennis Balkir commented on OFBIZ-10001:

In this one there is one special case of setting a field.
In the method {{createDownloadContentForCategory}} the field 
{{createCategoryContentMap.contentId}} is set from {{parameters.contentId}}.

I learned that if the field which gets set isn't {{null}}, but the field that 
it will get set from is {{null}}, nothing will happen.

This is because the Java implementation of the MiniLang method {{set}} will 
perform a check against null for the {{from-field}}, which in this case is 
important, because {{parameters.contentId}} was {{null}} in most of my tests, 
which first resulted in a wrong output of this method.

I hope this will help reviewing this patch.


All the methods were tested and seem to work for the tests I did.

> Convert CategoryContentServices.xml mini lang to groovy
> -------------------------------------------------------
>                 Key: OFBIZ-10001
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10001
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Priority: Minor
>         Attachments: 
> OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch
> Migration of the CategoryContentServices.xml to Groovy

This message was sent by Atlassian JIRA

Reply via email to