[ 
https://issues.apache.org/jira/browse/OFBIZ-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395083#comment-16395083
 ] 

Garima jain edited comment on OFBIZ-9240 at 3/12/18 11:16 AM:
--------------------------------------------------------------

I spent some time around it and found that
1. If the user is currently logged in and requests for login again from URL 
then, instead of redirecting it to 'main' screen, it redirects to the login 
screen and displays the error message.

Actual: If the user is currently logged in and requests for login again from 
URL, then the user should redirect to the 'main' screen.
This issue also exists in e-commerce and backend.

To fix it: We can check the value of 'isUserLoggedIn()' in LoginWorker.java 
file. If 'isUserLoggedIn()' returns true, we can return a string "userLoggedIn" 
which we can check in the controller to redirect it to the main screen.
for reference: screenshots attached. 

!backend.png!


was (Author: garima.jain):
I spent some time around it and found that
1. If the user is currently logged in and requests for login again from URL 
then, instead of redirecting it to 'main' screen, it redirects to the login 
screen and displays the error message.

Actual: If the user is currently logged in and requests for login again from 
URL, then the user should redirect to the 'main' screen.
This issue also exists in e-commerce and backend.

To fix it: We can check the value of 'isUserLoggedIn()' in LoginWorker.java 
file. If 'isUserLoggedIn()' returns true, we can return a string "userLoggedIn" 
which we can check in the controller to redirect it to the main screen.
for reference: screenshots attached. !backend.png!

> Ecommerce login/logout don't work properly for trunk and stable and even old
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-9240
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9240
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, 
> Release Branch 16.11
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 16.11.04
>
>         Attachments: OFBIZ-9240.patch, backend.png, ecomseo.png
>
>
> Here are the tests I did and their results.  I did not consider R14/15 
> because of OFBIZ-9235
> h5. On demos before fixing OFBIZ-9206 and using ofbiz-vm2 direct access
> h6. ecomseo trunk and stable (R16)
> # Get to https://demo-trunk.ofbiz.apache.org/ecomseo/ or 
> https://demo-stable.ofbiz.apache.org/ecomseo/
> # login => main page logged in
> # logout => main page, not logged in
> # login => main page logged in
> # Use the "Not you" link => 404
> # Refresh (F5 key)  get you to the main page, not logged in
> So it works almost correctly but you need a refresh (F5 key) for the "Not 
> you" link, not sure why yet.
> It"s the same locally with OFBIZ-9206 fixed*, w/ or w/o portoffset
> h6. ecommerce trunk and stable (R16)
> # Get to https://ofbiz-vm2.apache.org:8443/ecommerce or 
> https://ofbiz-vm2.apache.org:18443/ecommerce
> # login => blank page (no 404 in access log)
> # Refresh (F5 key)  get you to the main page, logged in
> # logout => blank page (no 404 in access log)
> # Refresh (F5 key)  get you to the main page, not logged in
> # login => blank page (no 404 in access log)
> # Refresh (F5 key)  get you to the main page, logged in
> # use the "Not you" link => blank page (no 404 in access log)
> # Refresh (F5 key)  get you to the main page, not logged in
> So it works almost correctly but you need a refresh (F5 key) between in the 3 
> cases, not sure why yet.
> It's the same locally *with OFBIZ-9206 fixed*, w/ or w/o portoffset
> h6. Old (R13) on demo (no ecomseo before R14)
> # Get to https://ofbiz-vm2.apache.org:28443/ecommerce
> # login => you need to enter it twice => main page logged in
> # logout => main page, not logged in
> # login  => main page logged in
> # use the "Not you" link => main page, not logged in
> So it "works" but initially you need to enter the credential twice to login
> It's the same locally *with OFBIZ-9206 "fixed" (I'm not yet sure about that, 
> I need to test on demo)*, w/ or w/o portoffset



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to