[
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-10304:
-------------------------------------
I reopen this issue after this discussion on dev ML:
https://markmail.org/message/yjlpzrwy7ptnvll6
I think we need to revisit OFBIZ-10047 because I found another occurence of the
problem in
payPalCheckoutUpdate. Jacopo said he will review the Tomcat SSO code and I'll
try too.
> The "request" attribute type of the userLogin service is wrong
> --------------------------------------------------------------
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
> Issue Type: Bug
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Major
> Fix For: 17.12.01
>
>
> I commited
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679
> which I guess forced (or allowed?) James Yong to use the
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the
> userLogin service at
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133
> Else it would (should?) have been
> <attribute name="request" mode="IN"
> type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and
> silly (my bad).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
