[ 
https://issues.apache.org/jira/browse/OFBIZ-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417529#comment-16417529
 ] 

Scott Gray edited comment on OFBIZ-6882 at 3/28/18 4:00 PM:
------------------------------------------------------------

The main problem is that "house number" is too specific for a generic data 
model because it implies the building at this street number is a house. 

I don't have a problem with recording one or two numbers in separate fields 
that specify a location detail for address1, I only have a problem with the 
naming.

I don't have a problem with cityGeoId, I understand it can be desirable for the 
city to constrained to the available Geo records rather than free text input.

For municipalityGeoId, municipality is a new construct for the data model and I 
would have preferred more discussion around the use case and to have seen some 
samples provided.

 

None of this is about attempting to be "smart" or treating google as a source 
of truth.  It's about collaboration and using our shared experience and 
knowledge to come to a conclusion that is suitable for as many use cases as 
possible.  Ignoring review comments and making passive aggressive comments is 
not healthy for the community or the code.

 


was (Author: lektran):
The main problem is that "house number" is too specific for a generic data 
model because it implies the building at this street number is a house. 

I don't have a problem with recording one or two numbers in separate fields 
that specify a location detail for address1, I only have a problem with the 
naming.

I don't have a problem with cityGeoId, I understand it can be desirable for the 
city to constrained to the available Geo records rather than free text input.

For municipalityGeoId, municipality is a new construct for the data model and I 
won't have preferred more discussion around the use case and to have seen some 
samples provided.

 

None of this is about attempting to be "smart" or treating google as a source 
of truth.  It's about collaboration and using our shared experience and 
knowledge to come to a conclusion that is suitable for as many use cases as 
possible.  Ignoring review comments and making passive aggressive comments is 
not healthy for the community or the code.

 

> Extend the PostalAddress entity with additional elements
> --------------------------------------------------------
>
>                 Key: OFBIZ-6882
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6882
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>              Labels: 3rdParty, Shipment, integration
>             Fix For: 16.11.01
>
>         Attachments: OFBIZ-6882-party-PostalAddress.patch
>
>
> Various modern day 3rd party delivery solutions (e.g. PostNL in The 
> Netherlands) require that elements are delivered separately, so that 
> addresses can be checked more easily.
> Current definition of the PostalAddress doesn't have separation of:
> * street name
> * house number
> * house number addition or extension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to