[ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457426#comment-16457426
 ] 

Nicolas Malin commented on OFBIZ-10331:
---------------------------------------

Hi Dennis, I checked some patches and I have a issue with 
[^OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch] with display the form 
 !Sélection_156.png!

I didn't know if it the waiting result.

A little problem for with patch 
OFBIZ-10221_order.template.order.FindOrders.patch
{code:java}
poveglia$ patch -p1 < 
~/Téléchargements/OFBIZ-10221_order.template.order.FindOrders.patch
patching file applications/order/template/order/FindOrders.ftl
patch: **** malformed patch at line 434: </tr>
{code}
and patch OFBiz-10221_order.template.order.OrderInfo.patch
{code:java}
poveglia$ svn info
Révision : 1830238

poveglia$ patch -p1 < 
~/Téléchargements/OFBiz-10221_order.template.order.OrderInfo.patch
patching file applications/order/template/order/OrderInfo.ftl
Hunk #1 succeeded at 96 (offset -4 lines).
...

Hunk #8 succeeded at 223 (offset -4 lines).
Hunk #9 FAILED at 236.
Hunk #10 FAILED at 253.
Hunk #11 FAILED at 270.
Hunk #12 succeeded at 285 (offset -5 lines).
3 out of 12 hunks FAILED -- saving rejects to file 
applications/order/template/order/OrderInfo.ftl.rej{code}
I will continue the review later for other patches

thanks for your thorough work

> Improve Order
> -------------
>
>                 Key: OFBIZ-10331
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10331
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Assignee: Deepak Dixit
>            Priority: Minor
>         Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to