[
https://issues.apache.org/jira/browse/OFBIZ-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10453.
-----------------------------------
Resolution: Implemented
Thanks Mathieu,
Your slightly modified patches are in trunk at revision 1834662.
I appreciate you separated the 2 aspects, easier to review. Maybe saying that
one patch should be applied before the others would help ;) Actually I spotted
it before applying while reviewing the patch, so was not really an issue :).
It's a matter of taste, I just put {{throws WebAppConfigurationException}} on
the same line than the methods signatures, in this case I find it easier to
read because it's not too long.
> Factorize code logic from ‘ConfigXMLReader’
> -------------------------------------------
>
> Key: OFBIZ-10453
> URL: https://issues.apache.org/jira/browse/OFBIZ-10453
> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Reporter: Mathieu Lirzin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10453_0001-Add-ConfigXMLReader.ControllerConfig-pushIncludes.patch,
> OFBIZ-10453_0002-Add-ConfigXMLReader.ControllerConfig-getIncludes.patch
>
>
> There is a lot of repetitive code in {{ConfigXMLReader}}. Using a functional
> interface as a parameter of a generic algorithm avoids those repetitions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
