[
https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535306#comment-16535306
]
Gil Portenseigne commented on OFBIZ-10458:
------------------------------------------
While looking at the work to add aliases in all groovy for UtilValidate, i
found out that only two usage of this class are not ifEmpty/ifNotEmpty usage.
UtilValidate.areEqual(product?.primaryProductCategoryId,
parameters.productCategoryId)) {
UtilValidate.checkValidDatabaseId(newEntity.productCategoryId)
So i think it should be best to use
[Groovy-Truth|http://groovy-lang.org/semantics.html#Groovy-Truth] that should
suffice for most cases. Sorry for disgressing on this JIRA. I will commit it
with UtilValidate removal.
> GetLocaleList call can provide duplicate results
> ------------------------------------------------
>
> Key: OFBIZ-10458
> URL: https://issues.apache.org/jira/browse/OFBIZ-10458
> Project: OFBiz
> Issue Type: Bug
> Reporter: Mathieu Lirzin
> Assignee: Gil Portenseigne
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10458_0001-Add-failing-tests.patch,
> OFBIZ-10458_0002-Fix-duplicates-bug.patch, OFBIZ-10458_0003-Refactor.patch
>
>
> This is not a huge issue but I detected an issue with the {{GetLocaleList}}
> script which when providing both a {{localeString}} and {{localeName}} can
> provide duplicate results.
> Here is a set of 3 patches that should be applied in order:
> - the first one is adding some tests with a failing one which identifies the
> bug
> - the second one resolves the bug
> - the third one refactors the code to use a more functional style
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
