[
https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539623#comment-16539623
]
Dennis Balkir edited comment on OFBIZ-10464 at 7/11/18 6:34 AM:
----------------------------------------------------------------
Hi Jacques,
there is actually no difference seen, the only difference is in the code.
Before the change, the screenlets didn't just "sit" in the surrounding page
containers, but were nested inside a table.
Since this wasn't something I found anywhere else in the code, I removed it to
make the whole HTML more equal and more friendly to stylize.
The main page from AR had the same issue
You wrote:
{quote}
bq. Most of the times, the main screens just include .ftl files
Which is a pity. For instance you improved catalog/control/main with r1829700
for OFBIZ-10221. But then the fields are no longer aligned. So I have created
OFBIZ-10454. We should only use form widgets in the backend to easily keep
things concistent. Unfortunately we have a ton of legacy to change. Anyway,
thanks for your good work {quote}
This was just something I noticed while comparing the other main pages to the
ones from AR and AP.
I think the main problem is not even, that there are FTL files used instead of
form widgets, but that there is no rule for the HTML code. There are so many
differences inside the HTML code because of this and frequently there is the
same looking menu, or form, or button, but the code is totally different in 3
of 4 cases.
FTL has some advantages, that in my opinion can come in very handy, but there
have to be some conventions how certain elements should be implemented, so that
there is some consistency in the code
was (Author: dennis balkir):
Hi Jacques,
there is actually no difference seen, the only difference is in the code.
Before the change, the screenlets didn't just "sit" in the surrounding page
containers, but were nested inside a table.
Since this wasn't something I found anywhere else in the code, I removed it to
make the whole HTML more equal and more friendly to stylize.
The main page from AR had the same issue
> Improve Accounting -AP
> ----------------------
>
> Key: OFBIZ-10464
> URL: https://issues.apache.org/jira/browse/OFBIZ-10464
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: accounting-ap_main-page.patch
>
>
> I found some structural differences while looking on accounting-ap -> main.
> While all the other screenlets on such pages are nested inside the
> surrounding div-containers, these ones are actually inside a table, which
> then is inside the normally surrounding divs.
>
> This makes styling for new themes difficult and should be changed, since it
> is an exception in the normally used structure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
