[ 
https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539769#comment-16539769
 ] 

Mathieu Lirzin commented on OFBIZ-10460:
----------------------------------------

I would recommend adding a "XXX" comment directly in the code explaining the 
reason why we are keeping the mismatch. If the explanation is unclear or too 
long to explain properly you can add a link to OFBIZ-10471.

> setLocaleFromBrowser requires authentification
> ----------------------------------------------
>
>                 Key: OFBIZ-10460
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10460
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Mathieu Lirzin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: 17.12.01
>
>
> The setLocaleFromBrowser request map defined in {{common-controller.xml}} has 
> an attribute of {{auth=false}}
> {code:xml}
> <request-map uri="setLocaleFromBrowser">
>     <security https="false" auth="false"/>
>     <event type="service" invoke="setLocaleFromBrowser"/>
>     <response name="success" type="request" value="json"/>
>     <response name="error" type="request" value="json"/>
> </request-map>
> {code}
> while the service associated with it in 
> {{framework/common/servicedef/services.xml}} has an attribute of 
> {{auth=true}}.
> {code:xml}
> <service name="setLocaleFromBrowser" engine="groovy" 
> location="component://common/groovyScripts/SetLocaleFromBrowser.groovy" 
> invoke="setLocaleFromBrowser" auth="true">
>     <description>Set locale from browser.</description>
>     <attribute name="localeName" type="String" mode="IN" optional="true"/>
> </service>
> {code}
> It seems like a (minor) bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to