[
https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571291#comment-16571291
]
Mathieu Lirzin commented on OFBIZ-10450:
----------------------------------------
Just for information, the extracted {{checkCertificates}} takes a {{validator}}
predicate argument in order to be able to unit test it. Otherwise the result
of the test would depend on {{SSLUtil.isClientTrusted}} implementation which
itself depends on the external
{{javax.net.ssl.X509TrustManager.checkClientTrusted}}, which result depends on
the certification authority certificates (CACerts) installed on the user system.
> Extract verification of certificates in ‘RequestHandler’
> --------------------------------------------------------
>
> Key: OFBIZ-10450
> URL: https://issues.apache.org/jira/browse/OFBIZ-10450
> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Reporter: Mathieu Lirzin
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch
>
>
> No functional change. Reduce the size of {{RequestHandler::doRequest}}
> method. Add some tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
