[ 
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588803#comment-16588803
 ] 

Suraj Khurana commented on OFBIZ-7598:
--------------------------------------

Thanks [~gil portenseigne],

Yes, you are absolutely correct. But we have one more case here for which I 
used ModelForm, we also allowed user to add custom 

empty-form-data-message from each form and if no such formElement found than we 
show generic 'No Record Found' message.
Does it sounds good to you as well ?
I have worked on this further and created patch using another property in 
ModelForm 'containsData' as  you suggested.
Can you please apply latest attached patch (OFBIZ-7598_improvement.patch) on 
trunk and check if everything looks good to you as well.

I am waiting for conclusion on [~jacques.le.roux] mail on dev ML 
([https://markmail.org/message/rvrzok4wta66i2t5)]

As per conclusion on it, I will proceed.

Thanks again for your inputs.

> Empty header row should not render if list to render in file is empty
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-7598
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7598
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, 
> OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png
>
>
> If list inside form doesn't contain data, then header row should not render 
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to