[
https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657835#comment-16657835
]
Mathieu Lirzin edited comment on OFBIZ-10458 at 10/20/18 11:43 AM:
-------------------------------------------------------------------
OK, I thought you were saying that the test was failing, but I think I
understand what you are talking about. Reading the test logs, I have found in
“{{build/test-results/test/TEST-org.apache.ofbiz.common.GetLocaleListTests.xml}}”
the stack trace you included in your message.
The error is related to the fact that {{org.apache.ofbiz.base.util.GroovyUtil}}
is failing to resolve the “{{component://base/config/GroovyInit.groovy}}”
location because the component container is not launched when running the unit
tests.
This error is simply logged and has no impact on the execution so I guess it is
not critical. Having said that I see no reason to make {{GroovyUtil}} depend
on the component container in the first place, so I suggest to replace the
location with “{{ofbizhome://framework/base/config/GroovyInit.groovy}}” instead
to fix this particular issue. WDYT?
was (Author: mthl):
OK; I thought you were saying that the test was failing, but I think I
understand what you are talking about. Reading the test logs, I have found in
“{{build/test-results/test/TEST-org.apache.ofbiz.common.GetLocaleListTests.xml}}”
the stack trace you included in your message.
The error is related to the fact that {{org.apache.ofbiz.base.util.GroovyUtil}}
is failing to resolve the “{{component://base/config/GroovyInit.groovy}}”
location because the component container is not launched when running the unit
tests.
This error is simply logged and has no impact on the execution so I guess it is
not critical. Having said that I see no reason to make {{GroovyUtil}} depend
on the component container in the first place, so I suggest to replace the
location with “{{ofbizhome://framework/base/config/GroovyInit.groovy}}” instead
to fix this particular issue. WDYT?
> GetLocaleList call can provide duplicate results
> ------------------------------------------------
>
> Key: OFBIZ-10458
> URL: https://issues.apache.org/jira/browse/OFBIZ-10458
> Project: OFBiz
> Issue Type: Bug
> Reporter: Mathieu Lirzin
> Assignee: Gil Portenseigne
> Priority: Minor
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-10458_0001-Add-failing-tests.patch,
> OFBIZ-10458_0002-Fix-duplicates-bug.patch, OFBIZ-10458_0003-Refactor.patch
>
>
> This is not a huge issue but I detected an issue with the {{GetLocaleList}}
> script which when providing both a {{localeString}} and {{localeName}} can
> provide duplicate results.
> Here is a set of 3 patches that should be applied in order:
> - the first one is adding some tests with a failing one which identifies the
> bug
> - the second one resolves the bug
> - the third one refactors the code to use a more functional style
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
