[ 
https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658140#comment-16658140
 ] 

Jacques Le Roux commented on OFBIZ-10458:
-----------------------------------------

Thanks Mathieu,

I tried your replacing suggestion with {{ofbizhome}} instead of {{component}}. 
I got no issues locally either recompiling and testing (integration). So I 
guess it's a good solution.
{quote}To investigate more I would suggest re-running locally the gradle 
command sequence with the same transition of SVN revisions that happened on the 
machine doing the trunk demo updates.
{quote}
Actually this happens everyday on trunk demo (I checked last 3 successively 
days). As it works locally and it's difficult to reproduce there, I suggest to 
commit this change and check that the error does no longer happen on the trunk 
demo.

I also noticed this comment (introduced with OFBIZ-6568) just above the line to 
change:
{code:java}
        /*
         *  With the implementation of @BaseScript annotations (introduced with 
Groovy 2.3.0) something was broken
         *  in the CompilerConfiguration.setScriptBaseClass method and an error 
is thrown when our scripts are executed;
         *  the workaround is to execute at startup a script containing the 
@BaseScript annotation.
         */
 {code}
It's seems related with the error I reported, I did not try the suggestion. 
Anyway it makes sense to me to use the ofbizhome notation since it seems to 
work and would be an integrated rather than external solution (at least for 
this error).

Note again that this error has not visible impact apart the logged error.

> GetLocaleList call can provide duplicate results
> ------------------------------------------------
>
>                 Key: OFBIZ-10458
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10458
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Mathieu Lirzin
>            Assignee: Gil Portenseigne
>            Priority: Minor
>             Fix For: 17.12.01, 16.11.05
>
>         Attachments: OFBIZ-10458_0001-Add-failing-tests.patch, 
> OFBIZ-10458_0002-Fix-duplicates-bug.patch, OFBIZ-10458_0003-Refactor.patch
>
>
> This is not a huge issue but I detected an issue with the {{GetLocaleList}} 
> script which when providing both a {{localeString}} and {{localeName}} can 
> provide duplicate results.
> Here is a set of 3 patches that should be applied in order:
>  - the first one is adding some tests with a failing one which identifies the 
> bug
>  - the second one resolves the bug
>  - the third one refactors the code to use a more functional style



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to