[ 
https://issues.apache.org/jira/browse/OFBIZ-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666526#comment-16666526
 ] 

Mathieu Lirzin commented on OFBIZ-10632:
----------------------------------------

Hello Jacques,

Hum I see.  If I understand the FindBug report correctly, I think it suggests 
using a fixed locale like {{Locale.ROOT for reproducible results. P}}assing 
{{Locale.getDefault()}} doesn't change/fix anything.

> ‘String#toLowercase()’ and ‘String#toUppercase()’ should be used when possible
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10632
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10632
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: 
> OFBIZ-10632_Use-String-toLowercase-and-String-toUppercase-when-p.patch
>
>
> Usage of {{"foo".toLowerCase()}} should be preferred to 
> {{"foo".toLowerCase(Locale.getDefault())}} which is equivalent but more 
> verbose. Likewise for {{toUpperCase()}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to