Jacques Le Roux commented on OFBIZ-10689:

Not quite, from {{ObjectTypeTests.java}} List, Map, Set, Calendar and sql.Date, 
are supported and are not [simple 

I'm not sure if there are no other not simple types covered,  not sure either 
if all simple types are covered. I guess Short is OK, but not sure for 
BigInteger, Byte, Character, ObjectName and Void...

I'd prefer to change the method name (confusing), maybe though we could simply 
improve the Javadoc, by adding all the supported types?

[~pfm.smits], Since you started it, would you like to work on it?

> function parseBigDecimalForEntity is in wrong location
> ------------------------------------------------------
>                 Key: OFBIZ-10689
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10689
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, 
> Release Branch 17.12
>            Reporter: Pierre Smits
>            Priority: Major
>         Attachments: OFBIZ-10689-simpleTypeOrObjectConvert.patch
> Currently the function 'parseBigDecimalForEntity' is located in 
> ProductEvents.java. 
> Given that this function applies to more than just products, this function 
> should be located in the framework stack.

This message was sent by Atlassian JIRA

Reply via email to