[ 
https://issues.apache.org/jira/browse/OFBIZ-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709379#comment-16709379
 ] 

Mathieu Lirzin commented on OFBIZ-10691:
----------------------------------------

I have included a series of patches to improve the current situation.  Those 
patches are meant to be applied in order and if they were to be committed I 
don't recommend squashing them since The resulting diff would become quite 
unreadable.  The rationale for each patch is included at the top of the file.

> Refactoring ‘EntityCondition’
> -----------------------------
>
>                 Key: OFBIZ-10691
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10691
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10691_0001-Remove-EntityConditionBase-class.patch, 
> OFBIZ-10691_0002-Turn-EntityCondition-into-an-interface.patch, 
> OFBIZ-10691_0003-Rename-EntityConditionFunction-class-into-EntityNotC.patch, 
> OFBIZ-10691_0004-Rewrite-EntityConditionList-class.patch, 
> OFBIZ-10691_0005-Rewrite-EntityFieldMap-class.patch, 
> OFBIZ-10691_0006-Rewrite-EntityWhereString-class.patch, 
> OFBIZ-10691_0007-Rewrite-EntityDateFilterCondition-class.patch, 
> OFBIZ-10691_0008-Rewrite-EntityExpr-class.patch, 
> OFBIZ-10691_0009-Rewrite-EntityConditionListBase-class.patch
>
>
> The {{EntityConditionBase}} class hierarchy is abusing inheritance in order 
> to share code between {{EntityCondition}}, {{EntityOperator}}, and 
> {{EntityConditionValue}}. Additionally it contains some dead code and some 
> poorly documented classes/methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to