[
https://issues.apache.org/jira/browse/OFBIZ-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714583#comment-16714583
]
Jacques Le Roux commented on OFBIZ-10697:
-----------------------------------------
OK let me explain my point.
By default OOTB debug.properties sets all debug levels to be used but verbose.
So there is no point checking other levels than verbose to see if they are
used, they are anyway. So OOTB only checking verbose is needed. That's what
developers need.
Now you invoked production where a different debug.properties setting would be
used. Sincerely I'd never, never, remove the other levels than verbose from a
production setting (as it's OOTB). I'd even be quite reluctant to remove any of
those levels from a production site running for years! *You never know what can
happen*, and those debug levels are your only lifebelt in case of issues, small
and big ones.
That's my point, and that's why I see checking if a level is used as premature
optimisation but for verbose. We need them anyway and IMO setting false for any
but verbose in debug.properties in production would be conceited if not
"suicidal" ;). But maybe you have use cases I ignore?
Anway, I'll start a discussion in dev ML about this point. Like I said above
and in OFBIZ-10448:
bq. I'd be all for removing the 312 useless cases but not the "if
(Debug.verboseOn())"
> ControlEventListener improvement: check debug level
> ---------------------------------------------------
>
> Key: OFBIZ-10697
> URL: https://issues.apache.org/jira/browse/OFBIZ-10697
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk, Release Branch 17.12
> Reporter: Michael Brohl
> Assignee: Michael Brohl
> Priority: Minor
>
> The Debug.logXXX statements should be preceded with a check for the debug
> level to optimize the performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
