[ 
https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727301#comment-16727301
 ] 

Aditya Sharma commented on OFBIZ-9089:
--------------------------------------

Looks good to me.

Thanks Yogesh :) 

Just a suggestion, as I can see in 
[AutoAcctgBudgetTests|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/applications/accounting/groovyScripts/test/AutoAcctgBudgetTests.groovy]
  there are methods to create and update we can follow a similar pattern here 
class name being 

*TestProductFeatureType* and method name *testCreateProductFeatureType.*

> Unit test case for service - createProductFeatureType
> -----------------------------------------------------
>
>                 Key: OFBIZ-9089
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9089
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Pradhan Yash Sharma
>            Assignee: Yogesh Naroliya
>            Priority: Minor
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-9089.patch, OFBIZ-9089.patch
>
>
> Unit test case for service - createProductFeatureType



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to