[ 
https://issues.apache.org/jira/browse/OFBIZ-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728416#comment-16728416
 ] 

Jacques Le Roux commented on OFBIZ-10673:
-----------------------------------------

Thanks for your feedback Rohit,

What a mess, it almost gives me headache when I try to follow the path.

So you say it was 1st broken by OFBIZ-4212 (r1081272), somehow fixed by 
r1081526, then broken again by OFBIZ-9776 (r1817623). 

I have double checked all that. Because r1081526 concern only 
*scaleImageInAllSize()*  and your patch concerns it also. But *filePathPrefix* 
is only changed by OFBIZ-9776 (r1817623) in *scaleImageManageInAllSize()*. So 
why do you speak about OFBIZ-9776 (r1817623) and *filePathPrefix*?

Also the fix done by OFBIZ-9776 (r1817623) seems good to me, why do you want to 
remove it? Maybe it fixes your issue (did nto try) but are you sure it does not 
put in regressions?

> Unable to add additional product images from catalog
> ----------------------------------------------------
>
>                 Key: OFBIZ-10673
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10673
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Rohit Koushal
>            Assignee: Rohit Koushal
>            Priority: Major
>         Attachments: OFBIZ-10673.patch, screenshot-1.png
>
>
> Unable to add additional product images from screen: Catalog > Products > 
> Content
> below is the screen for reference.
>  !screenshot-1.png! 
> ServerĀ logs:
> {code:java}
> 2018-11-24 18:40:52,454 |sse-nio-8443-exec-11 |CallService                   
> |E| ERROR: Could not complete the Method to upload multiple Additional View 
> images for product 
> [file:/home/rohit/sandbox/ofbiz-framework/applications/product/minilang/product/product/ProductContentServices.xml#uploadProductAdditionalViewImages]
>  process [problem invoking the [addAdditionalViewForProduct] service with the 
> map named [addAdditionalViewForProductMap] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-11-24 
> 11:21:56.719(java.sql.Timestamp)][createdTxStamp,2018-11-24 
> 11:21:56.716(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2018-11-24
>  14:59:33.347(java.sql.Timestamp)][lastUpdatedTxStamp,2018-11-24 
> 14:59:33.291(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  visualTheme=visual-theme-id:RAINBOWSTONE_SAPHIR, display-name: Rainbow Stone 
> - Sapphire, description: , screenshots: 
> [/rainbowstone/images/themeSaphir.png], productId=GZ-1000, 
> _uploadedFile_contentType=image/png, 
> timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=19800000,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
>  locale=en_US, productContentTypeId=ADDITIONAL_IMAGE_1, 
> uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=1174673 cap=1174673], 
> _uploadedFile_fileName=Screenshot from 2018-10-23 09:02:57.png}]: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)]
> org.apache.ofbiz.service.GenericServiceException: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)
>         at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
>  ~[ofbiz.jar:?]
>         at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  ~[ofbiz.jar:?]
>         at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  ~[ofbiz.jar:?]
>         at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  ~[ofbiz.jar:?]
>         at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>  ~[ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61) 
> [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
>         at org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
> [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
> [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:350)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:796)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:519)
>  [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>         at 
> org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81) 
> [ofbiz.jar:?]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:665) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>         at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>         at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
>  [ofbiz.jar:?]
>         at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>         at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408) 
> [tomcat-coyote-9.0.13.jar:9.0.13]
>         at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
>  [tomcat-coyote-9.0.13.jar:9.0.13]
>         at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:791)
>  [tomcat-coyote-9.0.13.jar:9.0.13]
>         at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1417)
>  [tomcat-coyote-9.0.13.jar:9.0.13]
>         at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  [tomcat-coyote-9.0.13.jar:9.0.13]
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>         at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.13.jar:9.0.13]
>         at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: java.lang.NullPointerException
>         at 
> org.apache.ofbiz.product.product.ProductServices.addAdditionalViewForProduct(ProductServices.java:1092)
>  ~[ofbiz.jar:?]
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_66]
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_66]
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
>         at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
>         at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  ~[ofbiz.jar:?]
>         ... 48 more
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to