[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735614#comment-16735614
 ] 

Dennis Balkir commented on OFBIZ-4361:
--------------------------------------

Hi [~gil portenseigne],

I just have a small question. In my implementation, I designed it in a way, 
that the user who clicks on the link for the password reset has to provide the 
his/her username in the process.
I did that, so that it maybe would not be that easy to use another persons link 
to reset his/her password, should someone grab the mail.
With the token I wrote, it will then check, if the token ID provided in the 
link and the username entered by the user are connected correctly and if not, 
the user can not set a new password.

I may be a little paranoid, but I think this adds another level of security to 
this process. Is it possible to add a feature similar to this to the process? I 
don't really know what kind of limitations there are with the JWT, but I guess 
that should be possible somehow.

Thanks

PS: [~jacques.le.roux], I think your points are quite well exlplained. This 
seems like a valid solution, if I didn't miss anything, thanks for exlaining

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4361
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4361
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
>         Environment: Ubuntu and others
>            Reporter: mz4wheeler
>            Assignee: Jacques Le Roux
>            Priority: Major
>              Labels: security
>         Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to