[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740099#comment-16740099 ]
Mathieu Lirzin commented on OFBIZ-10607: ---------------------------------------- Thanks Michael for reviewing and applying this patch, Can you explain the issue with the patch I submitted? did it fail to apply with the metadata? I am using {{git format-patch --no-prefix}} to generate my patches which is a common practice in a lot of Free Software communities (Linux Kernel/most GNU packages). I am willing to adapt the format of my patches. I just want to understand what is the issue you are facing which is not obvious for me. > ‘EntityOperator#getId()’ is not used in the framework > ----------------------------------------------------- > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Trunk > Reporter: Mathieu Lirzin > Assignee: Michael Brohl > Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)