[ 
https://issues.apache.org/jira/browse/OFBIZ-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792428#comment-16792428
 ] 

Jacques Le Roux edited comment on OFBIZ-10837 at 3/14/19 8:36 AM:
------------------------------------------------------------------

Thanks to [Wolfgang Rauchholz on user 
ML|https://markmail.org/message/q5etvmwtkswgyakj], I completed the while list 
with sun.util.calendar.ZoneInfo + java.util.Date in
 trunk r1855488+1855492
 R18 r1855489+1855493
 R17 r1855490+1855494
 R16 r1855491+1855495


was (Author: jacques.le.roux):
Thanks to Wolfgang Rauchholz on user ML, I completed the while list with 
sun.util.calendar.ZoneInfo + java.util.Date in
 trunk r1855488+1855492
 R18 r1855489+1855493
 R17 r1855490+1855494
 R16 r1855491+1855495

> Improve ObjectInputStream class
> -------------------------------
>
>                 Key: OFBIZ-10837
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10837
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> As reported by FindBugs and Sonar, it's troubling (a Bad practice in 
> Sonar[1], a code smell in Findbugs[2]) when extending to use the same name 
> than the extended Object.[3]
> [1] 
> [https://sbforge.org/sonar/rules/show/findbugs:NM_SAME_SIMPLE_NAME_AS_SUPERCLASS?layout=false]
>  [2] [https://logging.apache.org/log4j/log4j-2.2/log4j-jul/findbugs.html]
>  [3] Bug: The class name org.apache.ofbiz.base.util.ObjectInputStream shadows 
> the simple name of the superclass java.io.ObjectInputStream
> This class has a simple name that is identical to that of its superclass, 
> except that its superclass is in a different package (e.g., alpha.Foo extends 
> beta.Foo). This can be exceptionally confusing, create lots of situations in 
> which you have to look at import statements to resolve references and creates 
> many opportunities to accidentally define methods that do not override 
> methods in their superclasses.
> Rank: Troubling (14), confidence: High
>  Pattern: NM_SAME_SIMPLE_NAME_AS_SUPERCLASS
>  Type: Nm, Category: BAD_PRACTICE (Bad practice)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to