[ 
https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810668#comment-16810668
 ] 

Jacques Le Roux edited comment on OFBIZ-10817 at 4/5/19 9:57 AM:
-----------------------------------------------------------------

I tried again putting an error in ecommerce main.ftl and by default I only see 
the stack trace in log. It's the same when I set widget.verbose=false. Also I 
just noticed that showjGrowl() is the one that shows the error message with no 
stack trace in both cases... Same when breaking main.ftl in product but w/o 
showjGrowl()...

Also I don't see any difference when I set
widget.verbose=false
widget.freemarker.template.verbose=true

And when I add
widget.freemarker.template.exception.message=ERROR ERROR ERROR
I don't see "ERROR ERROR ERROR" but the std error message
Error rendering included template at location 
[component://product/template/Main.ftl]: freemarker.core.ParseException: Syntax 
error in template "component://product/template/Main.ftl" in line 23, column 1: 
Unexpected directive, "". Check if you have a valid #if-#elseif-#else structure.


was (Author: jacques.le.roux):
I tried again putting an error in ecommerce main.ftl and by default I only see 
the stack trace in log. It's the same when I set widget.verbose=false. Also I 
just noticed that showjGrowl() is the one that shows the error message with no 
stack trace in both cases... Same when breaking main.ftl in product but w/o 
showjGrowl()...

Also I don't see any difference when I set 
widget.freemarker.template.verbose=true

And when I set 
widget.freemarker.template.exception.message=ERROR ERROR ERROR
I don't see "ERROR ERROR ERROR" but the std error message
Error rendering included template at location 
[component://product/template/Main.ftl]: freemarker.core.ParseException: Syntax 
error in template "component://product/template/Main.ftl" in line 23, column 1: 
Unexpected directive, "". Check if you have a valid #if-#elseif-#else structure.

> Configure stackTrace displaying on ftl rendering
> ------------------------------------------------
>
>                 Key: OFBIZ-10817
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10817
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, 
> OFBIZ-10817.patch, OFBIZ-10817.patch
>
>
> Currently when freemarker failed to execute a template, you have on end 
> screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property 
> widget.verbose is true, no regression during development and when you switch 
> to production site, in general your widget.verbose is false so end user 
> haven't stack trace (that totally unused for them).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to