[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829046#comment-16829046
]
Jacques Le Roux commented on OFBIZ-10725:
-----------------------------------------
Hi Aditya,
Even if this is not functional and minor, it's delicate, thanks for all your
work cleaning the code :)
I was wondering if we should close here. I just had a look and using this
regexp:
{code:java}
if \(.*\) \{\R.*return true;
{code}
I found
* 60 matches in applications
* 138 in framework
* 4 in plugins
I only checked the 1st two in applications and they really match (the regexp is
very simple).
While at it I improved 3 of the 4 in plugins (the other is in a loop) at
revision: 1858350
So let's keep it open, most if done, but if we get some spare time why not
continue :) For now I guess we have bigger fishes to fry even if it's always
hard to clearly define priority when it's about code.
> Refactor boolean returns from methods
> -------------------------------------
>
> Key: OFBIZ-10725
> URL: https://issues.apache.org/jira/browse/OFBIZ-10725
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Aditya Sharma
> Assignee: Aditya Sharma
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
