[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838369#comment-16838369 ]
Mathieu Lirzin edited comment on OFBIZ-10934 at 5/13/19 8:31 AM: ----------------------------------------------------------------- Hello, the [^OFBIZ10934-MORE.patch] contains some unrelated using {{Random#nextDouble}} instead of {{Math#random. Can you remove those?}} Personally I would find it more easy to review, if your patches were merged (meaning removing the old one and replacing it with an updated one) Thanks in advance. was (Author: mthl): Hello, the [^OFBIZ10934-MORE.patch] contains some unrelated using {{Random#nextDouble}} instead of {{Math#random. Can you remove those?}} Personally I would find it more easy to review, if your patches were merge (meaning removing the old one and replacing it with an updated one) Thanks in advance. > Performance Increase: Using replace() instead of replaceAll() when a regex is > not used increases performance > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-10934 > URL: https://issues.apache.org/jira/browse/OFBIZ-10934 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Trunk > Reporter: bd2019us > Priority: Trivial > Labels: pull-request-available > Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files > > > Affected files: > # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java > # > framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java > # > framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java > # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java > When replaceAll() is utilized and no regex is used, replaceAll() can be > replaced with replace() for better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)