[
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11029:
------------------------------------
Priority: Major (was: Critical)
Thanks for report Zhou,
This bug is major not critical. Critical bugs block releases by our
conventions. This should not block a release (even if I guess it will be
committed before next release).
> Issue in function getVariantSelectionFeatures of ProductWorker.java
> -------------------------------------------------------------------
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
> Reporter: Denglong Zhou
> Assignee: Aditya Sharma
> Priority: Major
> Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List<GenericValue> getVariantSelectionFeatures(GenericValue
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct =
> ProductWorker.getParentProduct(variantProduct.getString("productId"),
> variantProduct.getDelegator());
> if (virtualProduct == null ||
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null ||
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
