Jacques Le Roux commented on OFBIZ-11019:

Hi Mathieu,

I don't see a urgent need for that but indeed why not cleaning stuff. The patch 
applies on trunk HEAD and looks good to me (I did not test). 
BTW, I agree with Michael about deprecation rules and "notations": 

> Cleaning the bloated ‘Security’ interface
> -----------------------------------------
>                 Key: OFBIZ-11019
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11019
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: 
> OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch
> The ‘hasPermission(String, HttpSession)’ method declaration from the 
> ‘Security’ interface is breaking the minimality principle of interfaces 
> because it is easily expressible in term of ‘hasPermission(String, 
> GenericEntity)’. As a consequence a static helper method should be 
> implemented to achieve same convenience without polluting the ‘Security’ 
> interface.
> Other methods in that interface are suffering from the same issue.

This message was sent by Atlassian JIRA

Reply via email to