Jacques Le Roux commented on OFBIZ-10969:

Thanks Olivier,

>From what I understand it suffices to commit the patch at OFBIZ-11028 and then 
>both tickets can be closed. This implies, as you wrote above, that:

bq.  In the HR test scenario, I start by create an employee and after an 
employment, so all works ! In the recruitment test scenario I will create a 
Party (without role EMPLOYEE) and after selection process I will test 
createEmployment to check if it do the EMPLOYEE role creation.
For now, I have added in the createEmployment service the call to 
ensurePartyRoleTo service, so now it works, even if before, partyTo is'nt 
associated to roleType EMPLOYEE.

In other words, currently if an employment is created for a non employee this 
non employee will got an Employee role and so will be an employee. I tested 
this scenario, it works (a pay history is also created and editable) and it 
seems sound to me. In other words you don't need to create an employe from an 
existing person before creating an employment for this person. 

I commited the fix from OFBIZ-11028 in trunk at revision: 1859571

By default we always try to backport bugs fixes, so I did so here (actually in 
R18 r1859572
R17 r1859573
R17 r1859574 (conflict in HumanResServices.xml handled by hand)

> Unable to create Employments
> ----------------------------
>                 Key: OFBIZ-10969
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10969
>             Project: OFBiz
>          Issue Type: Bug
>          Components: humanres
>    Affects Versions: Trunk
>            Reporter: Arpit Mor
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: Image1.png
> Steps to regenerate:
>  # Login to the URL: 
> [https://demo-trunk.ofbiz.apache.org/humanres/control/main]
>  # Click on Employments
>  # Click on New Employments
>  # Click on Create
> Actual: Error message is displayed. Please refer attachment: Image1

This message was sent by Atlassian JIRA

Reply via email to