[ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849437#comment-16849437
 ] 

Jacques Le Roux commented on OFBIZ-7257:
----------------------------------------

Hi Devanshu,

Great job, at 1st glance your patch looks good to me and it works.

One minor label point:
{noformat}
+        <button type="submit">
+          Attach
+        </button>
{noformat}
Also while at it, please use this in your patch:
{noformat}
Index: CommonUiLabels.xml
===================================================================
--- CommonUiLabels.xml  (revision 1860177)
+++ CommonUiLabels.xml  (working copy)
@@ -1072,6 +1072,10 @@
         <value xml:lang="zh-CN">?</value>
         <value xml:lang="zh-TW">?</value>
     </property>
+    <property key="CommonAttachments">
+        <value xml:lang="en">Attachments</value>
+        <value xml:lang="fr">Pièces jointes</value>
+    </property>
     <property key="CommonAttentionName">
         <value xml:lang="ar">??? ????????</value>
         <value xml:lang="cs">K ruk�m</value>
{noformat}
I also found this in log. I don't think it's related to your work, maybe only 
the image formats I used which is not handled by our Tika version (I tried 2 
and did not see the Tika error for .png) . We need to check though (sorry not 
enough time right now) and open a new Jira if needed...
{noformat}
2019-05-28 09:30:50,947 |jsse-nio-8443-exec-5 |ControlServlet                
|T| [[[AddOrderAttachments(Domain:https://localhost)] Request Begun, 
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2019-05-28 09:30:50,961 |jsse-nio-8443-exec-5 |RequestHandler                
|I| Rendering View [AddOrderAttachments].  Hidden sessionId by default.
2019-05-28 09:30:50,962 |jsse-nio-8443-exec-5 |ServiceDispatcher             
|T| Sync service [order/getUserPreferenceGroup] finished in [1] milliseconds
2019-05-28 09:30:50,971 |jsse-nio-8443-exec-5 |ScreenFactory                 
|I| Got 31 screens in 0.007s from: 
file:/C:/projectsASF/ofbiz/applications/order/widget/ordermgr/OrderViewScreens.xml
2019-05-28 09:30:51,043 |jsse-nio-8443-exec-5 |ScreenFactory                 
|I| Got 4 screens in 0.006s from: 
file:/C:/projectsASF/ofbiz/applications/order/widget/ordermgr/CommonScreens.xml
2019-05-28 09:30:51,049 |jsse-nio-8443-exec-5 |ScreenFactory                 
|I| Got 1 screens in 0.006s from: 
file:/C:/projectsASF/ofbiz/applications/commonext/widget/CommonScreens.xml
2019-05-28 09:30:51,094 |jsse-nio-8443-exec-5 |ServiceDispatcher             
|T| Sync service [order/getLastSystemInfoNote] finished in [14] milliseconds
2019-05-28 09:30:51,114 |jsse-nio-8443-exec-5 |ScreenFactory                 
|I| Got 28 screens in 0.008s from: 
file:/C:/projectsASF/ofbiz/framework/common/widget/CommonScreens.xml
2019-05-28 09:30:51,191 |jsse-nio-8443-exec-5 |ScreenFactory                 
|I| Got 27 screens in 0.007s from: 
file:/C:/projectsASF/ofbiz/themes/common-theme/widget/CommonScreens.xml
2019-05-28 09:30:51,262 |jsse-nio-8443-exec-5 |ServerHitBin                  
|I| Visit delegatorName=default, ServerHitBin delegatorName=default
2019-05-28 09:30:51,290 |jsse-nio-8443-exec-5 |ControlServlet                
|T| [[[AddOrderAttachments(Domain:https://localhost)] Request Done- 
total:0.343,since last([AddOrderAttachme...):0.343]]
2019-05-28 09:31:56,176 |jsse-nio-8443-exec-2 |ControlServlet                
|T| [[[addOrderAttachments(Domain:https://localhost)] Request Begun, 
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2019-05-28 09:31:56,192 |jsse-nio-8443-exec-2 |ConfigXMLReader               
|I| controller loaded: 0.001s, 16 requests, 14 views in 
file:/C:/projectsASF/ofbiz/plugins/birt/webapp/ordermgr/WEB-INF/controller.xml
2019-05-28 09:31:56,214 |jsse-nio-8443-exec-2 |ConfigXMLReader               
|I| controller loaded: 0.004s, 376 requests, 152 views in 
file:/C:/projectsASF/ofbiz/applications/order/webapp/ordermgr/WEB-INF/controller.xml
2019-05-28 09:31:56,229 |jsse-nio-8443-exec-2 |ConfigXMLReader               
|I| controller loaded: 0.0s, 51 requests, 23 views in 
file:/C:/projectsASF/ofbiz/framework/common/webcommon/WEB-INF/common-controller.xml
2019-05-28 09:31:56,243 |jsse-nio-8443-exec-2 |ConfigXMLReader               
|I| controller loaded: 0.0s, 0 requests, 0 views in 
file:/C:/projectsASF/ofbiz/framework/common/webcommon/WEB-INF/handlers-controller.xml
2019-05-28 09:31:56,259 |jsse-nio-8443-exec-2 |ConfigXMLReader               
|I| controller loaded: 0.0s, 4 requests, 0 views in 
file:/C:/projectsASF/ofbiz/applications/commonext/webapp/WEB-INF/controller.xml
2019-05-28 09:31:56,280 |jsse-nio-8443-exec-2 |ConfigXMLReader               
|I| controller loaded: 0.003s, 379 requests, 154 views in 
file:/C:/projectsASF/ofbiz/applications/content/webapp/content/WEB-INF/controller.xml
2019-05-28 09:31:56,323 |jsse-nio-8443-exec-2 |ModelService                  
|I| Set default value [DOCUMENT] for parameter [contentTypeId]
2019-05-28 09:31:56,324 |jsse-nio-8443-exec-2 |GroupServiceModel             
|I| Running grouped service [createContentFromUploadedFile]
2019-05-28 09:31:56,325 |jsse-nio-8443-exec-2 |GroupServiceModel             
|I| Running grouped service [createDataResource]
2019-05-28 09:31:56,358 |jsse-nio-8443-exec-2 |Log                           
|W| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This 
simple-method-call is deprecated! Please use a service-call of 
genericBasePermissionC
heck instead.
2019-05-28 09:31:56,442 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/genericBasePermissionCheck] finished in [84] 
milliseconds
2019-05-28 09:31:56,504 |jsse-nio-8443-exec-2 |UtilProperties                
|I| ResourceBundle DefaultMessagesUiLabels (fr) created in 0.062s with 3 
properties
2019-05-28 09:31:56,505 |jsse-nio-8443-exec-2 |Log                           
|I| [DataResourcePermissionServices.xml#genericDataResourcePermission line 69] 
Admin permission found: CONTENTMGR_CREATE
2019-05-28 09:31:56,505 |jsse-nio-8443-exec-2 |Log                           
|I| [DataResourcePermissionServices.xml#genericDataResourcePermission line 73] 
Permission service [CREATE / ] completed; returning hasPermission = true
2019-05-28 09:31:56,505 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/genericDataResourcePermission] finished in [180] 
milliseconds
2019-05-28 09:31:56,532 |jsse-nio-8443-exec-2 |SequenceUtil                  
|I| Got bank of sequenced IDs for [DataResource]; curSeqId=10010, 
maxSeqId=10020, bankSize=10
May 28, 2019 9:31:56 AM org.apache.tika.config.InitializableProblemHandler$3 
handleInitializableProblem
WARNING: J2KImageReader not loaded. JPEG2000 files will not be processed.
See https://pdfbox.apache.org/2.0/dependencies.html#jai-image-io
for optional dependencies.

May 28, 2019 9:31:56 AM org.apache.tika.config.InitializableProblemHandler$3 
handleInitializableProblem
WARNING: org.xerial's sqlite-jdbc is not loaded.
Please provide the jar on your classpath to parse sqlite files.
See tika-parsers/pom.xml for the correct version.
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (partyId) is not found in context for createDataResource, 
defaulting to null.
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|W| doRealCompare returned null, returning false
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| For Service ECA [createDataResource] on [commit] got false for condition: 
[partyId][is-not-empty][true][String]
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (partyId) is not found in context for createDataResource, 
defaulting to null.
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|W| doRealCompare returned null, returning false
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| For Service ECA [createDataResource] on [commit] got false for condition: 
[partyId][is-not-empty][true][String]
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (partyId) is not found in context for createDataResource, 
defaulting to null.
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (roleTypeId) is not found in context for createDataResource, 
defaulting to null.
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaSetField            
|I| Expanded String: admin
2019-05-28 09:31:57,628 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| Running Service ECA Service: createDataResourceRole, triggered by rule on 
Service: createDataResource
2019-05-28 09:31:57,638 |jsse-nio-8443-exec-2 |Log                           
|W| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This 
simple-method-call is deprecated! Please use a service-call of 
genericBasePermissionC
heck instead.
2019-05-28 09:31:57,644 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/genericBasePermissionCheck] finished in [6] milliseconds
2019-05-28 09:31:57,644 |jsse-nio-8443-exec-2 |Log                           
|I| [DataResourcePermissionServices.xml#genericDataResourcePermission line 69] 
Admin permission found: CONTENTMGR_CREATE
2019-05-28 09:31:57,644 |jsse-nio-8443-exec-2 |Log                           
|I| [DataResourcePermissionServices.xml#genericDataResourcePermission line 73] 
Permission service [CREATE / ] completed; returning hasPermission = true
2019-05-28 09:31:57,644 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/genericDataResourcePermission] finished in [7] 
milliseconds
2019-05-28 09:31:57,645 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| Running Service ECA Service: ensurePartyRole, triggered by rule on Service: 
createDataResourceRole
2019-05-28 09:31:57,674 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/ensurePartyRole] finished in [29] milliseconds
2019-05-28 09:31:57,750 |jsse-nio-8443-exec-2 |UtilProperties                
|I| ResourceBundle ServiceUiLabels (fr) created in 0.07s with 4 properties
2019-05-28 09:31:57,750 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createDataResourceRole] finished in [116] milliseconds
2019-05-28 09:31:57,750 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createDataResource] finished in [1425] milliseconds
2019-05-28 09:31:57,750 |jsse-nio-8443-exec-2 |GroupServiceModel             
|I| Running grouped service [attachUploadToDataResource]
2019-05-28 09:31:57,752 |jsse-nio-8443-exec-2 |UtilProperties                
|I| ResourceBundle content.properties (fr) created in 0.001s with 15 properties
2019-05-28 09:31:57,765 |jsse-nio-8443-exec-2 |DataResourceWorker            
|I| Directory Name : 1559028255595
2019-05-28 09:31:57,765 |jsse-nio-8443-exec-2 |Log                           
|I| [DataServices.xml#saveLocalFileDataResource line 357] 
[attachLocalFileToDataResource] - Found Subdir : 
C:/projectsASF/ofbiz/runtime/uploads/1559028255595
2019-05-28 09:31:57,793 |jsse-nio-8443-exec-2 |EntityEcaRule                 
|I| Running Entity ECA Service: indexProductsFromDataResource, triggered by 
rule on Entity: DataResource
2019-05-28 09:31:57,805 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [entity-default/indexProductsFromDataResource] finished in 
[12] milliseconds
2019-05-28 09:31:57,849 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createAnonFile] finished in [43] milliseconds
2019-05-28 09:31:57,850 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/attachUploadToDataResource] finished in [100] 
milliseconds
2019-05-28 09:31:57,850 |jsse-nio-8443-exec-2 |GroupServiceModel             
|I| Running grouped service [createContentFromDataResource]
2019-05-28 09:31:57,850 |jsse-nio-8443-exec-2 |ModelService                  
|I| Set default value [CTNT_IN_PROGRESS] for parameter [statusId]
2019-05-28 09:31:57,905 |jsse-nio-8443-exec-2 |Log                           
|W| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This 
simple-method-call is deprecated! Please use a service-call of 
genericBasePermissionC
heck instead.
2019-05-28 09:31:57,906 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/genericBasePermissionCheck] finished in [1] milliseconds
2019-05-28 09:31:57,906 |jsse-nio-8443-exec-2 |Log                           
|I| [ContentPermissionServices.xml#genericContentPermission line 101] Admin 
permission found: CONTENTMGR_CREATE
2019-05-28 09:31:57,906 |jsse-nio-8443-exec-2 |Log                           
|I| [ContentPermissionServices.xml#genericContentPermission line 105] 
Permission service [CREATE / ] completed; returning hasPermission = true
2019-05-28 09:31:57,907 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/genericContentPermission] finished in [24] milliseconds
2019-05-28 09:31:57,919 |jsse-nio-8443-exec-2 |SequenceUtil                  
|I| Got bank of sequenced IDs for [Content]; curSeqId=10010, maxSeqId=10020, 
bankSize=10
2019-05-28 09:31:57,919 |jsse-nio-8443-exec-2 |PrimaryKeyFinder              
|I| Returning null because found incomplete primary key in find: 
[GenericEntity:Content][contentId,null()]
2019-05-28 09:31:57,956 |jsse-nio-8443-exec-2 |EntityEcaRule                 
|I| Running Entity ECA Service: indexContentKeywords, triggered by rule on 
Entity: Content
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [entity-default/indexContentKeywords] finished in [223] 
milliseconds
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (partyId) is not found in context for createContent, defaulting 
to null.
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|W| doRealCompare returned null, returning false
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| For Service ECA [createContent] on [commit] got false for condition: 
[partyId][is-not-empty][true][String]
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (partyId) is not found in context for createContent, defaulting 
to null.
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|W| doRealCompare returned null, returning false
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| For Service ECA [createContent] on [commit] got false for condition: 
[partyId][is-not-empty][true][String]
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (partyId) is not found in context for createContent, defaulting 
to null.
2019-05-28 09:31:58,179 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (roleTypeId) is not found in context for createContent, 
defaulting to null.
2019-05-28 09:31:58,180 |jsse-nio-8443-exec-2 |ServiceEcaSetField            
|I| Expanded String: admin
2019-05-28 09:31:58,180 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| Running Service ECA Service: createContentRole, triggered by rule on 
Service: createContent
2019-05-28 09:31:58,181 |jsse-nio-8443-exec-2 |Log                           
|W| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This 
simple-method-call is deprecated! Please use a service-call of 
genericBasePermissionC
heck instead.
2019-05-28 09:31:58,183 |jsse-nio-8443-exec-2 |Log                           
|I| [ContentPermissionServices.xml#genericContentPermission line 101] Admin 
permission found: CONTENTMGR_CREATE
2019-05-28 09:31:58,183 |jsse-nio-8443-exec-2 |Log                           
|I| [ContentPermissionServices.xml#genericContentPermission line 105] 
Permission service [CREATE / 10010] completed; returning hasPermission = true
2019-05-28 09:31:58,183 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/genericContentPermission] finished in [3] milliseconds
2019-05-28 09:31:58,183 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| Running Service ECA Service: ensurePartyRole, triggered by rule on Service: 
createContentRole
2019-05-28 09:31:58,184 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/ensurePartyRole] finished in [1] milliseconds
2019-05-28 09:31:58,184 |jsse-nio-8443-exec-2 |PrimaryKeyFinder              
|I| Returning null because found incomplete primary key in find: 
[GenericEntity:ContentRole][contentId,10010(java.lang.String)][fromDate,null()][partyId,admin(j
ava.lang.String)][roleTypeId,OWNER(java.lang.String)]
2019-05-28 09:31:58,188 |jsse-nio-8443-exec-2 |EntityEcaRule                 
|I| Running Entity ECA Service: indexContentKeywords, triggered by rule on 
Entity: ContentRole
2019-05-28 09:31:58,204 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [entity-default/indexContentKeywords] finished in [16] 
milliseconds
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createContentRole] finished in [25] milliseconds
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (contentAssocTypeId) is not found in context for createContent, 
defaulting to null.
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|W| doRealCompare returned null, returning false
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| For Service ECA [createContent] on [commit] got false for condition: 
[contentAssocTypeId][is-not-empty][true][String]
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (contentAssocTypeId) is not found in context for createContent, 
defaulting to null.
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|W| doRealCompare returned null, returning false
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| For Service ECA [createContent] on [commit] got false for condition: 
[contentAssocTypeId][is-not-empty][true][String]
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|I| From Field (contentPurposeTypeId) is not found in context for 
createContent, defaulting to null.
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaCondition           
|W| doRealCompare returned null, returning false
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceEcaRule                
|I| For Service ECA [createContent] on [commit] got false for condition: 
[contentPurposeTypeId][is-not-empty][true][String]
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createContent] finished in [323] milliseconds
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createContentFromDataResource] finished in [355] 
milliseconds
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createContentFromUploadedFile] finished in [1881] 
milliseconds
2019-05-28 09:31:58,205 |jsse-nio-8443-exec-2 |GroupServiceModel             
|I| Running grouped service [createOrderContent]
2019-05-28 09:31:58,221 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/createOrderContent] finished in [16] milliseconds
2019-05-28 09:31:58,221 |jsse-nio-8443-exec-2 |ServiceDispatcher             
|T| Sync service [order/uploadOrderContentFile] finished in [1898] milliseconds
2019-05-28 09:31:58,221 |jsse-nio-8443-exec-2 |RequestHandler                
|I| Ran Event [service:#uploadOrderContentFile] from [request], result is 
[success]
2019-05-28 09:31:58,223 |jsse-nio-8443-exec-2 |RequestHandler                
|I| Sending redirect to: 
[https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090].  Hidden 
sessionId by default.
2019-05-28 09:31:58,231 |jsse-nio-8443-exec-2 |UtilObject                    
|E| null
java.io.NotSerializableException: java.nio.HeapByteBuffer
        at 
java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184) 
~[?:1.8.0_202]
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348) 
~[?:1.8.0_202]
        at java.util.HashMap.internalWriteEntries(HashMap.java:1793) 
~[?:1.8.0_202]
        at java.util.HashMap.writeObject(HashMap.java:1363) ~[?:1.8.0_202]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_202]
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_202]
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_202]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
        at 
java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1140) 
~[?:1.8.0_202]
        at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496) 
~[?:1.8.0_202]
        at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432) 
~[?:1.8.0_202]
        at 
java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178) 
~[?:1.8.0_202]
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348) 
~[?:1.8.0_202]
        at java.util.HashMap.internalWriteEntries(HashMap.java:1793) 
~[?:1.8.0_202]
        at java.util.HashMap.writeObject(HashMap.java:1363) ~[?:1.8.0_202]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_202]
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_202]
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_202]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
        at 
java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1140) 
~[?:1.8.0_202]
        at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496) 
~[?:1.8.0_202]
        at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432) 
~[?:1.8.0_202]
        at 
java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178) 
~[?:1.8.0_202]
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348) 
~[?:1.8.0_202]
        at org.apache.ofbiz.base.util.UtilObject.getBytes(UtilObject.java:63) 
[ofbiz.jar:?]
        at 
org.apache.ofbiz.webapp.control.RequestHandler.callRedirect(RequestHandler.java:870)
 [ofbiz.jar:?]
        at 
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:683)
 [ofbiz.jar:?]
        at 
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) 
[ofbiz.jar:?]
        at 
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:85) 
[ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:665) 
[javax.servlet-api-4.0.1.jar:4.0.1]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
[javax.servlet-api-4.0.1.jar:4.0.1]
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
[tomcat-embed-websocket-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:187) 
[ofbiz.jar:?]
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) 
[ofbiz.jar:?]
        at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
[javax.servlet-api-4.0.1.jar:4.0.1]
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
[tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
[tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:678)
 [tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) 
[tomcat-catalina-9.0.19.jar:9.0.19]
        at 
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408) 
[tomcat-coyote-9.0.19.jar:9.0.19]
        at 
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
 [tomcat-coyote-9.0.19.jar:9.0.19]
        at 
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:836)
 [tomcat-coyote-9.0.19.jar:9.0.19]
        at 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1747)
 [tomcat-coyote-9.0.19.jar:9.0.19]
        at 
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) 
[tomcat-coyote-9.0.19.jar:9.0.19]
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_202]
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_202]
        at 
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
 [tomcat-util-9.0.19.jar:9.0.19]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
2019-05-28 09:31:58,239 |jsse-nio-8443-exec-2 |ServerHitBin                  
|I| Visit delegatorName=default, ServerHitBin delegatorName=default
2019-05-28 09:31:58,244 |jsse-nio-8443-exec-2 |ControlServlet                
|T| [[[addOrderAttachments(Domain:https://localhost)] Request Done- 
total:2.068,since last([addOrderAttachme...):2.068]]
2019-05-28 09:31:58,490 |jsse-nio-8443-exec-5 |ControlServlet                
|T| [[[orderview(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- 
total:0.0,since last(Begin):0.0]]
{noformat}
About OrderContentType, yes please do, "Document" is fine with me :)

> View Image button on order detail page is not working
> -----------------------------------------------------
>
>                 Key: OFBIZ-7257
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7257
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Avnindra Sharma
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to