[
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853967#comment-16853967
]
Jacques Le Roux edited comment on OFBIZ-10895 at 6/2/19 1:14 PM:
-----------------------------------------------------------------
I was wrong doing massive changes w/o close control.
I decided to revert the r1859576 and r1859807 commits and to backport the revert
The only safe way to go is to not only check the error log for "Unknown
request [...." but also to look for 404 in access log, not all requests show
erroneously in error log. This for all the branches including trunk!
Done in
trunk r1860526
R18 r1860527
R17 r1860528
R16 r1860529
was (Author: jacques.le.roux):
I was wrong doing massive changes w/o close control.
I decided to revert the r1859576 and r1859807 commits and to backport the revert
The only safe way to go is to not only check the error log for "Unknown
request [...." but also to look for 404 in access log, not all request show
erroneously in error log. This for all the branches including trunk!
Done in
trunk r1860526
R18 r1860527
R17 r1860528
R16 r1860529
> Unknown request [images]; this request does not exist or cannot be called
> directly.
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, themes
> Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]-
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [images]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:834)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1415)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [?:1.8.0_202]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [?:1.8.0_202]
> at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> [tomcat-util-9.0.16.jar:9.0.16]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
> 2019-03-31 12:32:26,223 |jsse-nio-8443-exec-7 |ControlServlet
> |E| An error occurred, going to the errorPage:
> file:/C:/projectsASF/ofbiz/framework/common/webcommon/error/Error.ftl
> 2019-03-31 12:32:26,224 |jsse-nio-8443-exec-2 |RequestHandler
> |I| Rendering View [LookupProduct]. Hidden sessionId by default.
> 2019-03-31 12:32:26,227 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Done- total:0.005,since
> last([images(Domain:ht...):0.005]]
> 2019-03-31 12:32:26,227 |jsse-nio-8443-exec-2 |ServiceDispatcher
> |T| Sync service [catalog/getUserPreferenceGroup] finished in [3] milliseconds
> 2019-03-31 12:32:26,236 |jsse-nio-8443-exec-2 |ScreenFactory
> |I| Got 9 screens in 0.008s from:
> file:/C:/projectsASF/ofbiz/applications/product/widget/catalog/LookupScreens.xml
> 2019-03-31 12:32:26,259 |jsse-nio-8443-exec-2 |Log
> |W| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This
> simple-method-call is deprecated! Please use a service-call of
> genericBasePermissionC
> heck instead.
> 2019-03-31 12:32:26,317 |jsse-nio-8443-exec-2 |ServiceDispatcher
> |T| Sync service [catalog/genericBasePermissionCheck] finished in [58]
> milliseconds
> 2019-03-31 12:32:26,317 |jsse-nio-8443-exec-2 |ServiceEcaCondition
> |W| doRealCompare returned null, returning false
> 2019-03-31 12:32:26,317 |jsse-nio-8443-exec-2 |ServiceEcaRule
> |I| For Service ECA [catalogPermissionCheck] on [return] got false for
> condition: [hasPermission][equals][false][true][Boolean]
> 2019-03-31 12:32:26,318 |jsse-nio-8443-exec-2 |ServiceDispatcher
> |T| Sync service [catalog/catalogPermissionCheck] finished in [81]
> milliseconds
> 2019-03-31 12:32:26,574 |jsse-nio-8443-exec-2 |ConfigXMLReader
> |I| controller loaded: 0.004s, 539 requests, 178 views in
> file:/C:/projectsASF/ofbiz/applications/product/webapp/catalog/WEB-INF/controller.xml
> 2019-03-31 12:32:26,593 |jsse-nio-8443-exec-2 |ConfigXMLReader
> |I| controller loaded: 0.0s, 51 requests, 23 views in
> file:/C:/projectsASF/ofbiz/framework/common/webcommon/WEB-INF/common-controller.xml
> 2019-03-31 12:32:26,613 |jsse-nio-8443-exec-2 |ConfigXMLReader
> |I| controller loaded: 0.0s, 0 requests, 0 views in
> file:/C:/projectsASF/ofbiz/framework/common/webcommon/WEB-INF/handlers-controller.xml
> 2019-03-31 12:32:26,632 |jsse-nio-8443-exec-2 |ConfigXMLReader
> |I| controller loaded: 0.0s, 26 requests, 10 views in
> file:/C:/projectsASF/ofbiz/framework/common/webcommon/WEB-INF/portal-controller.xml
> 2019-03-31 12:32:26,654 |jsse-nio-8443-exec-2 |ConfigXMLReader
> |I| controller loaded: 0.0s, 4 requests, 0 views in
> file:/C:/projectsASF/ofbiz/applications/commonext/webapp/WEB-INF/controller.xml
> 2019-03-31 12:32:26,656 |jsse-nio-8443-exec-2 |ServerHitBin
> |I| Visit delegatorName=default, ServerHitBin delegatorName=default
> 2019-03-31 12:32:26,657 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Done-
> total:0.442,since last([LookupProduct(Do...):0.442]]
> {noformat}
> Of after a request (here login):
> {noformat}
> 2019-03-31 13:53:00,396 |jsse-nio-8443-exec-6 |ControlServlet
> |T| [[[login(Domain:https://localhost)] Request Done- total:0.827,since
> last([login(Domain:htt...):0.827]]
> 2019-03-31 13:53:08,897 |jsse-nio-8443-exec-1 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]-
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 13:53:08,898 |jsse-nio-8443-exec-1 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [images]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:834)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1415)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [?:1.8.0_202]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [?:1.8.0_202]
> at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> [tomcat-util-9.0.16.jar:9.0.16]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
> 2019-03-31 13:53:08,899 |jsse-nio-8443-exec-1 |ControlServlet
> |E| An error occurred, going to the errorPage:
> file:/C:/projectsASF/ofbiz/framework/common/webcommon/error/Error.ftl
> {noformat}
> It shows only in log and have no effect on UI. Notably the new feature
> normally showing an error message in trunl (OFBIZ-10753) does not shows
> This happens in all supported releases. IIRW it always happened, only URLs
> like https://demo-trunk.ofbiz.apache.org/images/defaultImage.jpg work. But
> here it's different because we don't need to call
> https://demo-trunk.ofbiz.apache.org/images by hand to get the issue in log.
> So it's not very bad since it's has no side effects, just weird and annoying.
> Because it might hide something undetected yet...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
