[
https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870165#comment-16870165
]
Suraj Khurana commented on OFBIZ-10150:
---------------------------------------
Hello,
+1 to make the field length consistent for all entities. Just for information,
supplierProductId is not part of primary key in both the entities.
I think we are good here with the available patch. It looks good to me.
Any other thoughts are welcome !!
> supplierProductId Should Have Consistent Types Across Entities.
> ---------------------------------------------------------------
>
> Key: OFBIZ-10150
> URL: https://issues.apache.org/jira/browse/OFBIZ-10150
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: Trunk
> Environment: all
> Reporter: jesse thomas
> Assignee: Rohit Hukkeri
> Priority: Minor
> Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId
> was too long. So I looked up the fields and noticed that the order item
> entity had a different type for the field than the supplier product entity. I
> think it would be a good idea to pick one so the two fields can be treated
> consistently. I would vote for id-long, but I think either way it would be
> good to have them be the same type. There are other fields that have this
> issue too if you are interested?
>
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:
> <entity entity-name="OrderItem".......
> <field name="supplierProductId" type="id-long"></field>
> applications/datamodel/entitydef/product-entitymodel.xml:
> <entity entity-name="SupplierProduct"......
> <field name="supplierProductId" type="id"></field>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
